Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 86320e6033bcdd1bfeb96d10e6647c2358e24248
https://github.com/WebKit/WebKit/commit/86320e6033bcdd1bfeb96d10e6647c2358e24248
Author: Abrar Rahman Protyasha <a_protya...@apple.com>
Date: 2025-07-29 (Tue, 29 Jul 2025)
Changed paths:
M Tools/TestWebKitAPI/SourcesCocoa.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentSecurityPolicy.mm
R Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentSecurityPolicyTestHelpers.h
R Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentSecurityPolicyTestHelpers.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTestHelpers.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTestHelpers.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm
R Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm
M Tools/TestWebKitAPI/Tests/ios/ApplicationStateTracking.mm
R Tools/TestWebKitAPI/ios/TestPDFHostViewController.h
R Tools/TestWebKitAPI/ios/TestPDFHostViewController.mm
Log Message:
-----------
WKPDFView API tests are no longer necessary
https://bugs.webkit.org/show_bug.cgi?id=296653
rdar://157052720
Reviewed by Aditya Keerthi.
This patch is a prequel to WKPDFView removal (c.f. webkit.org/b/296654).
WKPDFView is no longer the default PDF configuration on trunk. In this
patch, we do a couple of things:
- Migrate (most) tests from WKPDFView.mm to the UnifiedPDF test suite.
- Remove WKPDFView-specific tests.
- Remove WKPDFView.mm and TestPDFHostViewController, which was written
as test support for WKPDFView.
- Remove WKPDFView-specific FindInPage API tests.
- Remove the UnifiedPDF=OFF variant of LoadPDFWithSandboxCSPDirective.
Again, since test coverage for the OFF config is not necessary moving
forward. This allows us to remove ContentSecurityPolicyTestHelpers.
- Adjust the NavigatingFromPDFDoesNotLeaveWebViewInactive API test to
not stand up a swizzled PDFHostViewController, and instead use a
UnifiedPDFPlugin instead.
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentSecurityPolicy.mm:
(TEST(ContentSecurityPolicy, InvalidRequireTrustedTypesFor)):
(TEST(ContentSecurityPolicy, LoadPDFWithSandboxCSPDirective)): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentSecurityPolicyTestHelpers.h:
Removed.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentSecurityPolicyTestHelpers.mm:
Removed.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
(swizzledPerformTextSearchWithQueryString): Deleted.
(TEST(WebKit, FindInPDF)): Deleted.
(TEST(WebKit, FindInPDFAfterReload)): Deleted.
(TEST(WebKit, FindInPDFAfterFindInPage)): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(-[PDFPrintUIDelegate _webView:printFrame:pdfFirstPageSize:completionHandler:]):
(-[PDFPrintUIDelegate waitForPageSize]):
(-[PDFPrintUIDelegate lastPrintedFrame]):
(TestWebKitAPI::testPDFData):
(TestWebKitAPI::UNIFIED_PDF_TEST):
(TestWebKitAPI::checkFrame):
(TestWebKitAPI::isBackground):
(TestWebKitAPI::pdfServerWithSandboxCSPDirective):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm: Removed.
* Tools/TestWebKitAPI/Tests/ios/ApplicationStateTracking.mm:
(TestWebKitAPI::TEST(ApplicationStateTracking,
NavigatingFromPDFDoesNotLeaveWebViewInactive)):
* Tools/TestWebKitAPI/ios/TestPDFHostViewController.h: Removed.
* Tools/TestWebKitAPI/ios/TestPDFHostViewController.mm: Removed.
Canonical link: https://commits.webkit.org/298023@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
