Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc8615f6c27ba7b374ae8d88aa0497bff1f986cb
      
https://github.com/WebKit/WebKit/commit/bc8615f6c27ba7b374ae8d88aa0497bff1f986cb
  Author: Yulun Wu <yulun...@apple.com>
  Date:   2025-08-04 (Mon, 04 Aug 2025)

  Changed paths:
    M LayoutTests/TestExpectations
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001-expected.txt
    M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp

  Log Message:
  -----------
  [Layout][Grid] Mitigate incorrect baseline for vertical-lr flex/grid boxes.
https://bugs.webkit.org/show_bug.cgi?id=296443
<rdar://156628380>

Reviewed by Alan Baradlay.

Inline layout currently performs an unnecessary coordinate flip in

InlineDisplayContentBuilder::mapInlineRectLogicalToVisual()

for vertical-lr content.

This is not necessary for boxes that provide the correct coordinates
and baselines, which are then broken by this flip.

This change introduces a temporary fix in

LayoutIntegrationGeometryUpdate::baselineForBox()

by performing another flip for line-inverted writing modes. This ensures
that the baselines computed by the LayoutIntegrationGeometryUpdate will
allow the content to be rendered correctly.

 * LayoutTests/TestExpectations:
 * 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001-expected.txt:
 * Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp:
 (WebCore::LayoutIntegration::baselineForBox):

Canonical link: https://commits.webkit.org/298204@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to