Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5cb921272c01e41e5a4c8db532aaaabb9647d7c6
https://github.com/WebKit/WebKit/commit/5cb921272c01e41e5a4c8db532aaaabb9647d7c6
Author: Boris Dušek <bdu...@apple.com>
Date: 2025-08-04 (Mon, 04 Aug 2025)
Changed paths:
M LayoutTests/accessibility/ARIA-reflection-expected.txt
M LayoutTests/accessibility/ARIA-reflection.html
A LayoutTests/accessibility/aria-table-indextext-expected.txt
A LayoutTests/accessibility/aria-table-indextext.html
M LayoutTests/accessibility/display-contents/role-row-headers-expected.txt
M LayoutTests/accessibility/mac/aria-columnrowheaders-expected.txt
M LayoutTests/accessibility/table-attributes-expected.txt
M LayoutTests/accessibility/table-cell-spans-expected.txt
M LayoutTests/accessibility/table-cells-expected.txt
M LayoutTests/accessibility/table-multiple-tbodies-expected.txt
M LayoutTests/accessibility/table-thead-tfoot-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/AriaMixin-string-attributes.tentative-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-attribute-reflection-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/wai-aria/idlharness.window-expected.txt
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityTable.cpp
M Source/WebCore/accessibility/AccessibilityTableCell.cpp
M Source/WebCore/accessibility/AccessibilityTableCell.h
M Source/WebCore/accessibility/AccessibilityTableRow.cpp
M Source/WebCore/accessibility/AccessibilityTableRow.h
M Source/WebCore/accessibility/AriaAttributes.idl
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
M Source/WebCore/accessibility/mac/CocoaAccessibilityConstants.h
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
M Source/WebCore/html/HTMLAttributeNames.in
M Tools/DumpRenderTree/AccessibilityUIElement.cpp
M Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
Log Message:
-----------
AX: Implement ARIA 1.3 properties aria-colindextext and aria-rowindextext on
Apple platforms
https://bugs.webkit.org/show_bug.cgi?id=257142
rdar://problem/109669421
Reviewed by Tyler Wilcock.
Per spec, these define human-readable alternatives to aria-colindex and
aria-rowindex.
Makes WAI-ARIA idlharness WPT test fully pass now on macOS.
While at it, make DRT's handling of `null` JS strings returned by
AccessibilityUIElement::stringAttributeValue consistent with that of
WKRT, to be able to have same test expectation files / tests when
comparing and/or outputting result of `stringAttributeValue` that
returns a `null` (which is required for the new layout test in this
change).
* LayoutTests/accessibility/ARIA-reflection-expected.txt:
* LayoutTests/accessibility/ARIA-reflection.html:
* LayoutTests/accessibility/aria-table-indextext-expected.txt: Added.
* LayoutTests/accessibility/aria-table-indextext.html: Added.
* LayoutTests/accessibility/display-contents/role-row-headers-expected.txt:
* LayoutTests/accessibility/mac/aria-columnrowheaders-expected.txt:
* LayoutTests/accessibility/table-attributes-expected.txt:
* LayoutTests/accessibility/table-cell-spans-expected.txt:
* LayoutTests/accessibility/table-cells-expected.txt:
* LayoutTests/accessibility/table-multiple-tbodies-expected.txt:
* LayoutTests/accessibility/table-thead-tfoot-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/AriaMixin-string-attributes.tentative-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-attribute-reflection-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/wai-aria/idlharness.window-expected.txt:
* LayoutTests/platform/glib/TestExpectations: Ignored new test.
* LayoutTests/platform/ios/TestExpectations: Added new test.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable const):
* Source/WebCore/accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::axColumnIndexText const):
(WebCore::AccessibilityTableCell::axRowIndexText const):
* Source/WebCore/accessibility/AccessibilityTableCell.h:
* Source/WebCore/accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::axRowIndexText const):
* Source/WebCore/accessibility/AccessibilityTableRow.h:
* Source/WebCore/accessibility/AriaAttributes.idl:
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityRowIndexDescription]):
(-[WebAccessibilityObjectWrapper accessibilityColumnIndexDescription]):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
(WebCore::createIsolatedObjectData):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
* Source/WebCore/accessibility/mac/CocoaAccessibilityConstants.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
* Source/WebCore/html/HTMLAttributeNames.in:
* Tools/DumpRenderTree/AccessibilityUIElement.cpp:
(stringAttributeValueCallback): FIX: handle `null` string same as WKRT
(required for new test)
* Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::stringAttributeValue):
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::stringAttributeValue):
Canonical link: https://commits.webkit.org/298210@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
