Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a05da2f822997ac3c1db8e00faa5cb5d8ebed9b
      
https://github.com/WebKit/WebKit/commit/5a05da2f822997ac3c1db8e00faa5cb5d8ebed9b
  Author: Said Abou-Hallawa <s...@apple.com>
  Date:   2025-08-05 (Tue, 05 Aug 2025)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedInteger-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedInteger-initial-values-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedInteger.html
    M 
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedNumber-initial-values-expected.txt
    M Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp
    M Source/WebCore/svg/SVGFEConvolveMatrixElement.h

  Log Message:
  -----------
  Fix the defaults of the SVGFEConvolveMatrixElement properties
https://bugs.webkit.org/show_bug.cgi?id=203770
rdar://122586298

Reviewed by Nikolas Zimmermann.

The default of 'divisor' property should be 1.
The default of 'orderX' and 'orderY' properties should be 3.

SVGFEConvolveMatrixElement::parseAttribute() should set the attributes to out of
range values and handle this as an error when building the filter effect in
SVGFEConvolveMatrixElement::build().

* 
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedInteger-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedInteger-initial-values-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedInteger.html:
* 
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedNumber-initial-values-expected.txt:
* Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::attributeChanged):
(WebCore::SVGFEConvolveMatrixElement::isValidTargetXOffset const):
(WebCore::SVGFEConvolveMatrixElement::isValidTargetYOffset const):
(WebCore::SVGFEConvolveMatrixElement::createFilterEffect const):
* Source/WebCore/svg/SVGFEConvolveMatrixElement.h:

Canonical link: https://commits.webkit.org/298250@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to