[webkit-changes] [WebKit/WebKit] 8c1ac1: [Style] Convert border-image-* and mask-border-* t...

Tue, 05 Aug 2025 14:46:08 -0700 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c1ac181ea22e32b72c3a680f3faf3756958eb14
      
https://github.com/WebKit/WebKit/commit/8c1ac181ea22e32b72c3a680f3faf3756958eb14
  Author: Sam Weinig <s...@webkit.org>
  Date:   2025-08-05 (Tue, 05 Aug 2025)

  Changed paths:
    M LayoutTests/fast/css/mask-box-image-parsing-expected.txt
    M Source/WebCore/Headers.cmake
    M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSToStyleMap.cpp
    M Source/WebCore/css/CSSToStyleMap.h
    M Source/WebCore/css/values/CSSValueAggregates.h
    M Source/WebCore/rendering/BorderPainter.cpp
    M Source/WebCore/rendering/BorderPainter.h
    M Source/WebCore/rendering/InlineBoxPainter.cpp
    A Source/WebCore/rendering/NinePieceImagePainter.cpp
    A Source/WebCore/rendering/NinePieceImagePainter.h
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderBoxModelObject.cpp
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/style/BorderData.h
    R Source/WebCore/rendering/style/NinePieceImage.cpp
    R Source/WebCore/rendering/style/NinePieceImage.h
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleConstants.cpp
    M Source/WebCore/rendering/style/RenderStyleConstants.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.h
    M Source/WebCore/rendering/style/StyleReflection.h
    M Source/WebCore/style/StyleBuilderConverter.h
    M Source/WebCore/style/StyleBuilderCustom.h
    M Source/WebCore/style/StyleExtractorConverter.h
    M Source/WebCore/style/StyleExtractorCustom.h
    M Source/WebCore/style/StyleExtractorSerializer.h
    M Source/WebCore/style/StyleInterpolationFunctions.h
    M Source/WebCore/style/StyleInterpolationWrappers.h
    M Source/WebCore/style/StylePendingResources.cpp
    A Source/WebCore/style/values/backgrounds/StyleBorderImage.cpp
    A Source/WebCore/style/values/backgrounds/StyleBorderImage.h
    A Source/WebCore/style/values/backgrounds/StyleBorderImageOutset.cpp
    A Source/WebCore/style/values/backgrounds/StyleBorderImageOutset.h
    A Source/WebCore/style/values/backgrounds/StyleBorderImageRepeat.cpp
    A Source/WebCore/style/values/backgrounds/StyleBorderImageRepeat.h
    A Source/WebCore/style/values/backgrounds/StyleBorderImageSlice.cpp
    A Source/WebCore/style/values/backgrounds/StyleBorderImageSlice.h
    A Source/WebCore/style/values/backgrounds/StyleBorderImageSource.cpp
    A Source/WebCore/style/values/backgrounds/StyleBorderImageSource.h
    A Source/WebCore/style/values/backgrounds/StyleBorderImageWidth.cpp
    A Source/WebCore/style/values/backgrounds/StyleBorderImageWidth.h
    M Source/WebCore/style/values/backgrounds/StyleLineWidth.cpp
    M Source/WebCore/style/values/color/StyleColorMix.cpp
    M Source/WebCore/style/values/images/StyleImageWrapper.cpp
    M Source/WebCore/style/values/images/StyleImageWrapper.h
    A Source/WebCore/style/values/masking/StyleMaskBorder.cpp
    A Source/WebCore/style/values/masking/StyleMaskBorder.h
    A Source/WebCore/style/values/masking/StyleMaskBorderOutset.cpp
    A Source/WebCore/style/values/masking/StyleMaskBorderOutset.h
    A Source/WebCore/style/values/masking/StyleMaskBorderRepeat.cpp
    A Source/WebCore/style/values/masking/StyleMaskBorderRepeat.h
    A Source/WebCore/style/values/masking/StyleMaskBorderSlice.cpp
    A Source/WebCore/style/values/masking/StyleMaskBorderSlice.h
    A Source/WebCore/style/values/masking/StyleMaskBorderSource.cpp
    A Source/WebCore/style/values/masking/StyleMaskBorderSource.h
    A Source/WebCore/style/values/masking/StyleMaskBorderWidth.cpp
    A Source/WebCore/style/values/masking/StyleMaskBorderWidth.h
    M 
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Logging.h

  Log Message:
  -----------
  [Style] Convert border-image-* and mask-border-* to strong style types
https://bugs.webkit.org/show_bug.cgi?id=296862

Reviewed by Antti Koivisto.

Converts the border-image-* and mask-border-* family of CSS properties to
use strong style types, replacing `NinePieceImage` with separate
`Style::BorderImage` and `Style::MaskBorder` types. Painting stays shared
via a new `NinePieceImagePainter`.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSToStyleMap.cpp:
* Source/WebCore/css/CSSToStyleMap.h:
* Source/WebCore/css/values/CSSValueAggregates.h:
* Source/WebCore/rendering/BorderPainter.cpp:
* Source/WebCore/rendering/BorderPainter.h:
* Source/WebCore/rendering/InlineBoxPainter.cpp:
* Source/WebCore/rendering/NinePieceImagePainter.cpp: Added.
* Source/WebCore/rendering/NinePieceImagePainter.h: Added.
* Source/WebCore/rendering/RenderBox.cpp:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
* Source/WebCore/rendering/RenderElement.cpp:
* Source/WebCore/rendering/RenderLayer.cpp:
* Source/WebCore/rendering/style/BorderData.h:
* Source/WebCore/rendering/style/NinePieceImage.cpp: Removed.
* Source/WebCore/rendering/style/NinePieceImage.h: Removed.
* Source/WebCore/rendering/style/RenderStyle.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
* Source/WebCore/rendering/style/RenderStyleSetters.h:
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
* Source/WebCore/rendering/style/StyleReflection.h:
* Source/WebCore/style/StyleBuilderConverter.h:
* Source/WebCore/style/StyleBuilderCustom.h:
* Source/WebCore/style/StyleExtractorConverter.h:
* Source/WebCore/style/StyleExtractorCustom.h:
* Source/WebCore/style/StyleExtractorSerializer.h:
* Source/WebCore/style/StyleInterpolationFunctions.h:
* Source/WebCore/style/StyleInterpolationWrappers.h:
* Source/WebCore/style/StylePendingResources.cpp:
* Source/WebCore/style/values/backgrounds/StyleBorderImage.cpp: Added.
* Source/WebCore/style/values/backgrounds/StyleBorderImage.h: Added.
* Source/WebCore/style/values/backgrounds/StyleBorderImageOutset.cpp: Added.
* Source/WebCore/style/values/backgrounds/StyleBorderImageOutset.h: Added.
* Source/WebCore/style/values/backgrounds/StyleBorderImageRepeat.cpp: Added.
* Source/WebCore/style/values/backgrounds/StyleBorderImageRepeat.h: Added.
* Source/WebCore/style/values/backgrounds/StyleBorderImageSlice.cpp: Added.
* Source/WebCore/style/values/backgrounds/StyleBorderImageSlice.h: Added.
* Source/WebCore/style/values/backgrounds/StyleBorderImageSource.cpp: Added.
* Source/WebCore/style/values/backgrounds/StyleBorderImageSource.h: Added.
* Source/WebCore/style/values/backgrounds/StyleBorderImageWidth.cpp: Added.
* Source/WebCore/style/values/backgrounds/StyleBorderImageWidth.h: Added.
* Source/WebCore/style/values/backgrounds/StyleLineWidth.cpp:
* Source/WebCore/style/values/color/StyleColorMix.cpp:
* Source/WebCore/style/values/images/StyleImageWrapper.cpp:
* Source/WebCore/style/values/images/StyleImageWrapper.h:
* Source/WebCore/style/values/masking/StyleMaskBorder.cpp: Added.
* Source/WebCore/style/values/masking/StyleMaskBorder.h: Added.
* Source/WebCore/style/values/masking/StyleMaskBorderOutset.cpp: Added.
* Source/WebCore/style/values/masking/StyleMaskBorderOutset.h: Added.
* Source/WebCore/style/values/masking/StyleMaskBorderRepeat.cpp: Added.
* Source/WebCore/style/values/masking/StyleMaskBorderRepeat.h: Added.
* Source/WebCore/style/values/masking/StyleMaskBorderSlice.cpp: Added.
* Source/WebCore/style/values/masking/StyleMaskBorderSlice.h: Added.
* Source/WebCore/style/values/masking/StyleMaskBorderSource.cpp: Added.
* Source/WebCore/style/values/masking/StyleMaskBorderSource.h: Added.
* Source/WebCore/style/values/masking/StyleMaskBorderWidth.cpp: Added.
* Source/WebCore/style/values/masking/StyleMaskBorderWidth.h: Added.
* Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Logging.h:

Canonical link: https://commits.webkit.org/298261@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to