Title: [113113] trunk/Source/_javascript_Core
Revision
113113
Author
[email protected]
Date
2012-04-03 17:50:07 -0700 (Tue, 03 Apr 2012)

Log Message

Offlineasm ARM backend uses the wrong mnemonic for multiply
https://bugs.webkit.org/show_bug.cgi?id=83098
<rdar://problem/11168744>

Reviewed by Gavin Barraclough.
        
Use "mul" instead of "muls" since we're passing three operands, not two.

* offlineasm/armv7.rb:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (113112 => 113113)


--- trunk/Source/_javascript_Core/ChangeLog	2012-04-04 00:29:52 UTC (rev 113112)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-04-04 00:50:07 UTC (rev 113113)
@@ -1,3 +1,15 @@
+2012-04-03  Filip Pizlo  <[email protected]>
+
+        Offlineasm ARM backend uses the wrong mnemonic for multiply
+        https://bugs.webkit.org/show_bug.cgi?id=83098
+        <rdar://problem/11168744>
+
+        Reviewed by Gavin Barraclough.
+        
+        Use "mul" instead of "muls" since we're passing three operands, not two.
+
+        * offlineasm/armv7.rb:
+
 2012-04-03  Gavin Barraclough  <[email protected]>
 
         Linux crashes during boot

Modified: trunk/Source/_javascript_Core/offlineasm/armv7.rb (113112 => 113113)


--- trunk/Source/_javascript_Core/offlineasm/armv7.rb	2012-04-04 00:29:52 UTC (rev 113112)
+++ trunk/Source/_javascript_Core/offlineasm/armv7.rb	2012-04-04 00:50:07 UTC (rev 113113)
@@ -778,10 +778,10 @@
             emitArmV7Compact("lsrs", "lsrs", operands)
         when "muli", "mulp"
             if operands.size == 2 or operands[0] == operands[2] or operands[1] == operands[2]
-                emitArmV7("muls", operands)
+                emitArmV7("mul", operands)
             else
                 $asm.puts "mov #{operands[2].armV7Operand}, #{operands[0].armV7Operand}"
-                $asm.puts "muls #{operands[2].armV7Operand}, #{operands[2].armV7Operand}, #{operands[1].armV7Operand}"
+                $asm.puts "mul #{operands[2].armV7Operand}, #{operands[2].armV7Operand}, #{operands[1].armV7Operand}"
             end
         when "subi", "subp", "subis"
             emitArmV7Compact("subs", "subs", operands)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to