Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a1b9adff1ce2c11ff4687f3ecf3ade5f3c95d838
      
https://github.com/WebKit/WebKit/commit/a1b9adff1ce2c11ff4687f3ecf3ade5f3c95d838
  Author: Richard Robinson <richard_robins...@apple.com>
  Date:   2025-08-07 (Thu, 07 Aug 2025)

  Changed paths:
    M Source/bmalloc/CMakeLists.txt
    M Source/bmalloc/bmalloc.xcodeproj/project.pbxproj
    A Source/bmalloc/libpas/src/libpas/pas_backtrace_metadata.h
    M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h
    M Source/bmalloc/libpas/src/libpas/pas_report_crash_pgm_report.h

  Log Message:
  -----------
  [JSC] JSC should not depend on pas_lock.h
https://bugs.webkit.org/show_bug.cgi?id=297080
rdar://157786340

Reviewed by Abrar Rahman Protyasha and Justin Michaud.

To further support modularization of JSC's private headers, ensure that there 
is no transitive
dependency on pas_lock.h. This needs to be done because of the reasons outlined 
in 297469@main.

The dependency exists because of the following chain:

PASReportCrashPrivate.h -> pas_report_crash_pgm_report.h -> 
pas_probabilistic_guard_malloc_allocator.h
-> pas_large_heap.h -> pas_physical_memory_transaction.h -> pas_lock.h

To break this chain, factor out `pas_backtrace_metadata` into its own file, so 
then `pas_report_crash_pgm_report`
need not depend on `pas_probabilistic_guard_malloc_allocator.h`.

* Source/bmalloc/bmalloc.xcodeproj/project.pbxproj:
* Source/bmalloc/libpas/src/libpas/pas_backtrace_metadata.h: Added.
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h:
* Source/bmalloc/libpas/src/libpas/pas_report_crash_pgm_report.h:

Canonical link: https://commits.webkit.org/298368@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to