Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a374eeb3f95f422b9ad97ae6197569f79700f0df
https://github.com/WebKit/WebKit/commit/a374eeb3f95f422b9ad97ae6197569f79700f0df
Author: Yusuke Suzuki <ysuz...@apple.com>
Date: 2025-08-08 (Fri, 08 Aug 2025)
Changed paths:
M Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp
M Source/JavaScriptCore/parser/Lexer.cpp
M Source/JavaScriptCore/parser/Lexer.h
M Source/JavaScriptCore/parser/Parser.cpp
M Source/JavaScriptCore/parser/Parser.h
M Source/JavaScriptCore/parser/ParserTokens.h
M Source/JavaScriptCore/parser/SourceProviderCacheItem.h
Log Message:
-----------
[JSC] Location in JSToken is duplicate information
https://bugs.webkit.org/show_bug.cgi?id=297107
rdar://157820631
Reviewed by Yijia Huang.
JSLocation stored in JSToken is completely duplicate information. This
can be constructed by using m_startPosition and m_endPosition.
Originally only JSLocation exists, but we added m_startPosition and
m_endPosition later. As a result, we are storing duplicate information.
This patch removes it.
* Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::parse):
* Source/JavaScriptCore/parser/Lexer.cpp:
(JSC::Lexer<T>::fillTokenInfo):
(JSC::Lexer<T>::lexWithoutClearingLineTerminator):
(JSC::Lexer<T>::scanRegExp):
(JSC::Lexer<T>::scanTemplateString):
* Source/JavaScriptCore/parser/Lexer.h:
(JSC::Lexer::getToken):
(JSC::Lexer<T>::lexExpectIdentifier):
* Source/JavaScriptCore/parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::parseAsyncFunctionSourceElements):
(JSC::Parser<LexerType>::parseAsyncGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::parseVariableDeclarationList):
(JSC::Parser<LexerType>::createBindingPattern):
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseTryStatement):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parseArrayLiteral):
* Source/JavaScriptCore/parser/Parser.h:
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenLineStart):
(JSC::Parser::tokenLocation):
(JSC::Parser::internalSaveLexerState):
* Source/JavaScriptCore/parser/ParserTokens.h:
(JSC::JSToken::location const):
* Source/JavaScriptCore/parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::endFunctionToken const):
Canonical link: https://commits.webkit.org/298443@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
