Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b4b06190328046e759cfaee7711eac9277165ac
      
https://github.com/WebKit/WebKit/commit/7b4b06190328046e759cfaee7711eac9277165ac
  Author: Adrian Perez de Castro <ape...@igalia.com>
  Date:   2025-08-11 (Mon, 11 Aug 2025)

  Changed paths:
    M Source/WTF/wtf/Assertions.cpp
    M Source/WTF/wtf/Assertions.h
    M Source/WTF/wtf/Logging.cpp
    M Source/WebCore/PAL/pal/Logging.cpp
    M Source/WebCore/platform/Logging.cpp
    M Source/WebDriver/Logging.cpp
    M Source/WebGPU/WebGPU/Internal/Logging.cpp
    M Source/WebKit/Platform/Logging.cpp
    M Source/WebKitLegacy/mac/Misc/WebKitLogging.m
    M Tools/TestWebKitAPI/Tests/WebCore/Logging.cpp

  Log Message:
  -----------
  [Cocoa] Remove unneeded WTFLogChannel::subsystem
https://bugs.webkit.org/show_bug.cgi?id=295263

Reviewed by Alex Christensen.

The Cocoa ports only use the WTFLogChannel::subsystem struct member
when calling os_log_create(), and as with the other ports, the value
is picked from the LOG_CHANNEL_WEBKIT_SUBSYSTEM macro for every
WTFLogChannel instance. Therefore, it is possible to use the macro
directly in the os_log_create() call.

As the subsystem is always picked from LOG_CHANNEL_WEBKIT_SUBSYSTEM,
this also simplifies the DEFINE_LOG_CHANNEL_[WITH_DETAILS] macros to
remove the parameter and removes the need for DEFINE_*_LOG_CHANNEL
in each component, where it is possible to use DEFINE_LOG_CHANNEL
instead.

This is a follow-up to 296858@main.

* Source/WTF/wtf/Assertions.cpp:
* Source/WTF/wtf/Assertions.h:
* Source/WTF/wtf/Logging.cpp:
* Source/WebCore/PAL/pal/Logging.cpp:
* Source/WebCore/platform/Logging.cpp:
* Source/WebDriver/Logging.cpp:
* Source/WebGPU/WebGPU/Internal/Logging.cpp:
* Source/WebKit/Platform/Logging.cpp:
* Source/WebKitLegacy/mac/Misc/WebKitLogging.m:
* Tools/TestWebKitAPI/Tests/WebCore/Logging.cpp:

Canonical link: https://commits.webkit.org/298529@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to