Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5cd27f4a22dd07e7a4e84d93edc1f8909df37817
      
https://github.com/WebKit/WebKit/commit/5cd27f4a22dd07e7a4e84d93edc1f8909df37817
  Author: Alan Baradlay <za...@apple.com>
  Date:   2025-08-12 (Tue, 12 Aug 2025)

  Changed paths:
    M Source/WebCore/rendering/AutoTableLayout.cpp
    M Source/WebCore/rendering/RenderTableCell.cpp
    M Source/WebCore/rendering/RenderTableCell.h

  Log Message:
  -----------
  [orthogonal td] RenderTableCell::computeIntrinsicPadding should compute 
intrinsic padding in the table cell's logical direction
https://bugs.webkit.org/show_bug.cgi?id=297197

Reviewed by Antti Koivisto.

Intrinsic padding is specific to table layout. It's what makes cell content 
center aligned.

Let's make sure RenderTableCell::computeIntrinsicPadding computes this extra 
padding in the correct direction (table cell's direction).
In order to be able to compute this padding, we need to preserve the 
(logical)height of the cell content. This is similar to what flex layout needs 
to do (see (m_orthogonalCellContentIntrinsicHeight)

* Source/WebCore/rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeIntrinsicPadding):
* Source/WebCore/rendering/RenderTableCell.h:

Canonical link: https://commits.webkit.org/298569@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to