Title: [113139] trunk
- Revision
- 113139
- Author
- [email protected]
- Date
- 2012-04-03 22:05:37 -0700 (Tue, 03 Apr 2012)
Log Message
Don't parse "show" and "hide" as valid values for display property.
https://bugs.webkit.org/show_bug.cgi?id=83115
Reviewed by Adam Barth.
No new tests.
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
Modified Paths
Added Paths
Diff
Added: trunk/LayoutTests/fast/css/display-no-show-hide-expected.html (0 => 113139)
--- trunk/LayoutTests/fast/css/display-no-show-hide-expected.html (rev 0)
+++ trunk/LayoutTests/fast/css/display-no-show-hide-expected.html 2012-04-04 05:05:37 UTC (rev 113139)
@@ -0,0 +1,3 @@
+<!DOCTYPE html>
+<div>This text should be visible.</div>
+<div>This text should be visible.</div>
Added: trunk/LayoutTests/fast/css/display-no-show-hide.html (0 => 113139)
--- trunk/LayoutTests/fast/css/display-no-show-hide.html (rev 0)
+++ trunk/LayoutTests/fast/css/display-no-show-hide.html 2012-04-04 05:05:37 UTC (rev 113139)
@@ -0,0 +1,3 @@
+<!DOCTYPE html>
+<div style="display:show">This text should be visible.</div>
+<div style="display:hide">This text should be visible.</div>
Modified: trunk/Source/WebCore/ChangeLog (113138 => 113139)
--- trunk/Source/WebCore/ChangeLog 2012-04-04 05:00:54 UTC (rev 113138)
+++ trunk/Source/WebCore/ChangeLog 2012-04-04 05:05:37 UTC (rev 113139)
@@ -1,3 +1,15 @@
+2012-04-03 Luke Macpherson <[email protected]>
+
+ Don't parse "show" and "hide" as valid values for display property.
+ https://bugs.webkit.org/show_bug.cgi?id=83115
+
+ Reviewed by Adam Barth.
+
+ No new tests.
+
+ * css/CSSParser.cpp:
+ (WebCore::isValidKeywordPropertyAndValue):
+
2012-04-03 Yuta Kitamura <[email protected]>
Crash in WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel
Modified: trunk/Source/WebCore/css/CSSParser.cpp (113138 => 113139)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-04-04 05:00:54 UTC (rev 113138)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-04-04 05:05:37 UTC (rev 113139)
@@ -531,8 +531,8 @@
#if ENABLE(CSS_GRID_LAYOUT)
if (valueID == CSSValueWebkitGrid || valueID == CSSValueWebkitInlineGrid)
return true;
+#endif
break;
-#endif
case CSSPropertyEmptyCells: // show | hide | inherit
if (valueID == CSSValueShow || valueID == CSSValueHide)
return true;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
