Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b559d3d6ec26a12188a6855c86938030690086f1
https://github.com/WebKit/WebKit/commit/b559d3d6ec26a12188a6855c86938030690086f1
Author: Boris Dušek <bdu...@apple.com>
Date: 2025-08-12 (Tue, 12 Aug 2025)
Changed paths:
M Tools/DumpRenderTree/AccessibilityController.cpp
M Tools/DumpRenderTree/AccessibilityTextMarker.cpp
M Tools/DumpRenderTree/AccessibilityTextMarker.h
M Tools/DumpRenderTree/AccessibilityUIElement.cpp
M Tools/DumpRenderTree/AccessibilityUIElement.h
M Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm
M Tools/DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm
M Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
M Tools/DumpRenderTree/mac/AccessibilityCommonMac.mm
M Tools/DumpRenderTree/mac/AccessibilityControllerMac.mm
M Tools/DumpRenderTree/mac/AccessibilityNotificationHandler.mm
M Tools/DumpRenderTree/mac/AccessibilityTextMarkerMac.mm
M Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm
M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm
M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
Log Message:
-----------
[AX]: check-webkit-style: DRT/WKTR - resolve all `whitespace/end_of_line`
warnings
https://bugs.webkit.org/show_bug.cgi?id=297280
Reviewed by Tyler Wilcock.
This reduces warnings reported for DRT/WKTR accessibility code from ~270 to 22.
* Tools/DumpRenderTree/AccessibilityController.cpp:
(getElementAtPointCallback):
(getAccessibleElementByIdCallback):
(addNotificationListenerCallback):
* Tools/DumpRenderTree/AccessibilityTextMarker.cpp:
(AccessibilityTextMarker::getJSClass):
(isMarkerRangeEqualCallback):
(AccessibilityTextMarkerRange::getJSClass):
* Tools/DumpRenderTree/AccessibilityTextMarker.h:
* Tools/DumpRenderTree/AccessibilityUIElement.cpp:
(lineForIndexCallback):
(rangeForLineCallback):
(boundsForRangeCallback):
(rangeForPositionCallback):
(stringForRangeCallback):
(attributedStringForRangeCallback):
(attributedStringRangeIsMisspelledCallback):
(uiElementCountForSearchPredicateCallback):
(uiElementForSearchPredicateCallback):
(selectTextWithCriteriaCallback):
(indexOfChildCallback):
(headerElementAtIndexCallback):
(childAtIndexCallback):
(selectedChildAtIndexCallback):
(linkedUIElementAtIndexCallback):
(disclosedRowAtIndexCallback):
(ariaOwnsElementAtIndexCallback):
(ariaFlowToElementAtIndexCallback):
(selectedRowAtIndexCallback):
(rowAtIndexCallback):
(isEqualCallback):
(setValueCallback):
(elementAtPointCallback):
(isAttributeSupportedCallback):
(isAttributeSettableCallback):
(uiElementArrayAttributeValueCallback):
(uiElementAttributeValueCallback):
(cellForColumnAndRowCallback):
(setSelectedTextRangeCallback):
(textMarkerRangeForElementCallback):
(attributedStringForTextMarkerRangeContainsAttributeCallback):
(indexForTextMarkerCallback):
(textMarkerForIndexCallback):
(textMarkerRangeLengthCallback):
(nextTextMarkerCallback):
(previousTextMarkerCallback):
(stringForTextMarkerRangeCallback):
(endTextMarkerForBoundsCallback):
(startTextMarkerForBoundsCallback):
(textMarkerForPointCallback):
(textMarkerRangeForMarkersCallback):
(startTextMarkerForTextMarkerRangeCallback):
(endTextMarkerForTextMarkerRangeCallback):
(accessibilityElementForTextMarkerCallback):
(leftWordTextMarkerRangeForTextMarkerCallback):
(rightWordTextMarkerRangeForTextMarkerCallback):
(previousWordStartTextMarkerForTextMarkerCallback):
(nextWordEndTextMarkerForTextMarkerCallback):
(paragraphTextMarkerRangeForTextMarkerCallback):
(previousParagraphStartTextMarkerForTextMarkerCallback):
(nextParagraphEndTextMarkerForTextMarkerCallback):
(sentenceTextMarkerRangeForTextMarkerCallback):
(previousSentenceStartTextMarkerForTextMarkerCallback):
(nextSentenceEndTextMarkerForTextMarkerCallback):
(getIsValidCallback):
(addNotificationListenerCallback):
(textMarkerRangeMatchesTextNearMarkersCallback):
(AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(AccessibilityUIElement::previousTextMarker):
* Tools/DumpRenderTree/AccessibilityUIElement.h:
* Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:
(findAccessibleObjectById):
(AccessibilityController::accessibleElementById):
(AccessibilityController::addNotificationListener):
* Tools/DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
(AccessibilityTextMarker::platformTextMarker const):
* Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(concatenateAttributeAndValue):
(AccessibilityUIElement::elementTextLength):
(AccessibilityUIElement::fieldsetAncestorElement):
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::childrenCount):
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::headerElementAtIndex):
(AccessibilityUIElement::linkedElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::decreaseTextSelection):
(AccessibilityUIElement::stringForSelection):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringForElement):
(_CGPathEnumerationIteration):
(AccessibilityUIElement::pathDescription const):
(AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::removeNotificationListener):
(AccessibilityUIElement::numberAttributeValue):
* Tools/DumpRenderTree/mac/AccessibilityCommonMac.mm:
(searchPredicateParameterizedAttributeForSearchCriteria):
* Tools/DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::elementAtPoint):
(AccessibilityController::rootElement):
(AccessibilityController::addNotificationListener):
* Tools/DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler setCallback:]):
* Tools/DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
(AccessibilityTextMarker::platformTextMarker const):
* Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(descriptionOfValue):
(attributesOfElement):
(descriptionOfElements):
(selectTextParameterizedAttributeForCriteria):
(AccessibilityUIElement::childrenCount):
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::selectedChildAtIndex const):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::uiElementAttributeValue const):
(AccessibilityUIElement::numberAttributeValue const):
(AccessibilityUIElement::boolAttributeValue const):
(AccessibilityUIElement::isAttributeSettable):
(AccessibilityUIElement::isAttributeSupported):
(AccessibilityUIElement::parameterizedAttributeNames):
(AccessibilityUIElement::role):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::computedRoleString):
(AccessibilityUIElement::helpText const):
(AccessibilityUIElement::x):
(AccessibilityUIElement::y):
(AccessibilityUIElement::width):
(AccessibilityUIElement::height):
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):
(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::insertionPointLineNumber):
(AccessibilityUIElement::isPressActionSupported):
(AccessibilityUIElement::isIncrementActionSupported):
(AccessibilityUIElement::isDecrementActionSupported):
(AccessibilityUIElement::speakAs):
(AccessibilityUIElement::classList const):
(AccessibilityUIElement::ariaDropEffects const):
(AccessibilityUIElement::lineForIndex):
(AccessibilityUIElement::rangeForLine):
(AccessibilityUIElement::rangeForPosition):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
(AccessibilityUIElement::uiElementCountForSearchPredicate):
(AccessibilityUIElement::selectTextWithCriteria):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::horizontalScrollbar const):
(AccessibilityUIElement::verticalScrollbar const):
(AccessibilityUIElement::pathDescription const):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::setSelectedChild const):
(AccessibilityUIElement::url):
(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::isFocusable const):
(AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(AccessibilityUIElement::textMarkerRangeForElement):
(AccessibilityUIElement::selectedTextMarkerRange):
(AccessibilityUIElement::resetSelectedTextMarkerRange):
(AccessibilityUIElement::textMarkerRangeLength):
(AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
(AccessibilityUIElement::indexForTextMarker):
(AccessibilityUIElement::textMarkerForIndex):
(AccessibilityUIElement::previousTextMarker):
(AccessibilityUIElement::nextTextMarker):
(AccessibilityUIElement::stringForTextMarkerRange):
(AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(AccessibilityUIElement::endTextMarkerForBounds):
(AccessibilityUIElement::startTextMarkerForBounds):
(AccessibilityUIElement::textMarkerForPoint):
(AccessibilityUIElement::accessibilityElementForTextMarker):
(AccessibilityUIElement::startTextMarker):
(AccessibilityUIElement::endTextMarker):
(AccessibilityUIElement::setSelectedTextMarkerRange):
(AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
(AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
(AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
(AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
(AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
(AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
(AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
(AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
(AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
(AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
(convertMathMultiscriptPairsToString):
(AccessibilityUIElement::mathPostscriptsDescription const):
(AccessibilityUIElement::mathPrescriptsDescription const):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
(WTR::AccessibilityController::addNotificationListener):
(WTR::findAccessibleObjectById):
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::headerElementAtIndex):
(WTR::AccessibilityUIElement::linkedElement):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::attributedStringForElement):
(WTR::AccessibilityUIElement::fieldsetAncestorElement):
(WTR::AccessibilityUIElement::elementTextLength):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::pathDescription const):
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::AccessibilityController::removeNotificationListener):
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::selectTextParameterizedAttributeForCriteria):
(WTR::AccessibilityUIElement::helpText const):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar const):
(WTR::AccessibilityUIElement::verticalScrollbar const):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
Canonical link: https://commits.webkit.org/298590@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
