Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 701ef4b83ce6fb5b64a1469308f27b69ee13deea
https://github.com/WebKit/WebKit/commit/701ef4b83ce6fb5b64a1469308f27b69ee13deea
Author: Tyler Wilcock <[email protected]>
Date: 2025-08-13 (Wed, 13 Aug 2025)
Changed paths:
A LayoutTests/accessibility/dynamic-expanded-text-expected.txt
A LayoutTests/accessibility/dynamic-expanded-text.html
M LayoutTests/accessibility/mac/abbr-acronym-tags-expected.txt
M LayoutTests/accessibility/mac/abbr-acronym-tags.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.h
M Source/WebCore/accessibility/AccessibilityTableCell.cpp
M Source/WebCore/accessibility/AccessibilityTableCell.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
Log Message:
-----------
AX: AXProperty::{SupportsExpandedTextValue, ExpandedTextValue} are never
updated after dynamic page changes, resulting in stale values being served to
assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=297225
rdar://158060676
Reviewed by Joshua Hoffman.
Fix this by caching the components (the `title` and `abbr` attribute values)
necessary to serve AXProperty::{SupportsExpandedTextValue, ExpandedTextValue}
rather than caching those as properties themselves. These component-style
properties are much easier to keep up-to-date.
* LayoutTests/accessibility/dynamic-expanded-text-expected.txt: Added.
* LayoutTests/accessibility/dynamic-expanded-text.html: Added.
* LayoutTests/accessibility/mac/abbr-acronym-tags-expected.txt:
* LayoutTests/accessibility/mac/abbr-acronym-tags.html:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::expandedTextValue const):
(WebCore::AXCoreObject::supportsExpandedTextValue const):
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::nameAttribute const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::expandedTextValue const): Deleted.
(WebCore::AccessibilityRenderObject::supportsExpandedTextValue const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::expandedTextValue const): Deleted.
(WebCore::AccessibilityTableCell::supportsExpandedTextValue const): Deleted.
* Source/WebCore/accessibility/AccessibilityTableCell.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
(WebCore::shouldCacheElementName):
(WebCore::createIsolatedObjectData):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
Canonical link: https://commits.webkit.org/298617@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
