Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2322b125ed713bb88b104fb5aa5b9f8bfc258f7 https://github.com/WebKit/WebKit/commit/c2322b125ed713bb88b104fb5aa5b9f8bfc258f7 Author: Elliott Williams <e...@apple.com> Date: 2025-08-13 (Wed, 13 Aug 2025)
Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: ----------- Remove CredentialUpdaterShim interface from open source builds that will never be used https://bugs.webkit.org/show_bug.cgi?id=295500 rdar://155192244 Reviewed by Matthew Finkel. CredentialUpdaterShim is implemented via WebKitAdditions, but its interface is defined in open-source WebKit code. In the public build, we load the class dynamically via soft-linking to WebKitSwift, and then call methods on the class object. This should always be a message send to nil, and these message sends without a corresponding implementation confuses SPI checking. Fix by compiling out the calls entirely until this code is upstreamed. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: Canonical link: https://commits.webkit.org/298660@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes