Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 93eb9fa1ae00d745872b670fd1902aedb55f2b65
https://github.com/WebKit/WebKit/commit/93eb9fa1ae00d745872b670fd1902aedb55f2b65
Author: Elliott Williams <[email protected]>
Date: 2025-08-14 (Thu, 14 Aug 2025)
Changed paths:
M Tools/Scripts/libraries/webkitapipy/webkitapipy/allow.py
M Tools/Scripts/libraries/webkitapipy/webkitapipy/allow_unittest.py
M Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb_unittest.py
Log Message:
-----------
[webkitapipy] Use "?" to represent unknown class
https://bugs.webkit.org/show_bug.cgi?id=297370
rdar://158265152
Reviewed by Brianna Fan.
Follow-up to format changes in https://commits.webkit.org/298571@main.
Instead of allowing the selector to be not-class-bound string, or a
dictionary without a "class" key, require a class. The intention is to
encourage developers to provide a class binding when one is known, to
make allowlisted selectors more precise.
As a drive-by, refactor how tomli is used to simplify loading code and
provide a parsing error message that can be consumed by build systems.
* Tools/Scripts/libraries/webkitapipy/webkitapipy/allow.py:
(AllowList.from_dict):
(AllowList.from_file):
* Tools/Scripts/libraries/webkitapipy/webkitapipy/allow_unittest.py:
* Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb_unittest.py:
(TestSDKDB.test_audit_allowed_name_in_loaded_and_unloaded_allowlist):
(TestSDKDB.test_audit_unnecessary_allow_in_loaded_and_unloaded_allowlist):
(TestSDKDB.test_audit_unused_allow_multiple_allowlists):
Canonical link: https://commits.webkit.org/298694@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes