Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f18f19148f92e687817feedc04eb7f7532159b21
https://github.com/WebKit/WebKit/commit/f18f19148f92e687817feedc04eb7f7532159b21
Author: Lily Spiniolas <lily_spinio...@apple.com>
Date: 2025-08-14 (Thu, 14 Aug 2025)
Changed paths:
A
LayoutTests/fast/forms/button-explicit-types-match-input-types-expected.html
A LayoutTests/fast/forms/button-explicit-types-match-input-types.html
A
LayoutTests/fast/forms/form-control-refresh/button-without-explicit-type-does-not-display-as-submit-button-expected-mismatch.html
A
LayoutTests/fast/forms/form-control-refresh/button-without-explicit-type-does-not-display-as-submit-button.html
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderTheme.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
M Source/WebCore/rendering/ios/RenderThemeIOS.h
M Source/WebCore/rendering/ios/RenderThemeIOS.mm
Log Message:
-----------
<button> elements with no explicit type are displaying as submit buttons
https://bugs.webkit.org/show_bug.cgi?id=297416
rdar://158331127
Reviewed by Tim Horton and Aditya Keerthi.
Move `isSubmitStyleButton` from RenderThemeIOS into RenderThemeCocoa and use it
to detect input elements with type "submit", and button elements with explicit
type
"submit". Button elements with no specified type will now display the same as
inputs
and button elements with type "button".
* LayoutTests/fast/forms/button-explicit-types-match-input-types-expected.html:
Added.
* LayoutTests/fast/forms/button-explicit-types-match-input-types.html: Added.
*
LayoutTests/fast/forms/form-control-refresh/button-without-explicit-type-does-not-display-as-submit-button-expected-mismatch.html:
Added.
*
LayoutTests/fast/forms/form-control-refresh/button-without-explicit-type-does-not-display-as-submit-button.html:
Added.
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isSubmitButton const): Deleted.
* Source/WebCore/rendering/RenderTheme.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::controlSupportsTints const):
(WebCore::RenderThemeCocoa::paintButtonForVectorBasedControls):
(WebCore::RenderThemeCocoa::adjustButtonStyleForVectorBasedControls const):
(WebCore::RenderThemeCocoa::isSubmitStyleButton const):
* Source/WebCore/rendering/ios/RenderThemeIOS.h:
* Source/WebCore/rendering/ios/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustButtonLikeControlStyle const):
(WebCore::RenderThemeIOS::isSubmitStyleButton const): Deleted.
Canonical link: https://commits.webkit.org/298721@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
