Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 92b145d0fc92136385fec2fb32316036218c1115
https://github.com/WebKit/WebKit/commit/92b145d0fc92136385fec2fb32316036218c1115
Author: Taher Ali <[email protected]>
Date: 2025-08-14 (Thu, 14 Aug 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/container-queries/container-units-svglength-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/intersection-observer/svg-container-element-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/intersection-observer/svg-image-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/intersection-observer/svg-stroke-change-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-cap-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ic-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-px-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-rem-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-rlh-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-viewport-expected.txt
M LayoutTests/svg/custom/svg-parse-overflow-1-expected.txt
M LayoutTests/svg/custom/svg-parse-overflow-2-expected.txt
M LayoutTests/svg/custom/svg-parse-overflow-3-expected.txt
M LayoutTests/svg/custom/svg-parse-overflow-5-expected.txt
M LayoutTests/svg/dom/length-list-parser-expected.txt
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/svg/SVGLengthValue.cpp
M Source/WebCore/svg/SVGLengthValue.h
Log Message:
-----------
Refactor SVGLengthValue to use CSS values (css/values) for storage
https://bugs.webkit.org/show_bug.cgi?id=297096
rdar://157809123
Reviewed by Darin Adler.
Replace direct storage of float value and SVGLengthType with with CSS strong
value types.
This enables reuse of CSS parsing infrastructure and prepares for future support
of modern CSS units in SVG.
LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/container-queries/container-units-svglength-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/intersection-observer/svg-container-element-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/intersection-observer/svg-image-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/intersection-observer/svg-stroke-change-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-cap-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ic-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-px-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-rem-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-rlh-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-viewport-expected.txt:
LayoutTests/svg/custom/svg-parse-overflow-1-expected.txt:
LayoutTests/svg/custom/svg-parse-overflow-2-expected.txt:
LayoutTests/svg/custom/svg-parse-overflow-3-expected.txt:
LayoutTests/svg/custom/svg-parse-overflow-5-expected.txt:
LayoutTests/svg/dom/length-list-parser-expected.txt:
Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
Source/WebCore/svg/SVGLengthValue.cpp:
(WebCore::adjustValueForPercentageStorage):
(WebCore::createVariantForLengthType):
(WebCore::SVGLengthValue::SVGLengthValue):
(WebCore::SVGLengthValue::setValueAsString):
(WebCore::SVGLengthValue::lengthType const):
(WebCore::SVGLengthValue::isZero const):
(WebCore::SVGLengthValue::isRelative const):
(WebCore::SVGLengthValue::valueAsPercentage const):
(WebCore::SVGLengthValue::valueInSpecifiedUnits const):
(WebCore::SVGLengthValue::valueAsString const):
(WebCore::SVGLengthValue::valueAsAtomString const):
(WebCore::SVGLengthValue::valueForBindings const):
(WebCore::SVGLengthValue::setValueInSpecifiedUnits):
(WebCore::SVGLengthValue::setValue):
(WebCore::SVGLengthValue::convertToSpecifiedUnits):
(WebCore::lengthTypeToString): Deleted.
(WebCore::parseLengthType): Deleted.
(WebCore::SVGLengthValue::fromCSSPrimitiveValue): Deleted.
(WebCore::SVGLengthValue::toCSSPrimitiveValue const): Deleted.
Source/WebCore/svg/SVGLengthValue.h:
(WebCore::SVGLengthValue::lengthType const): Deleted.
(WebCore::SVGLengthValue::isZero const): Deleted.
(WebCore::SVGLengthValue::isRelative const): Deleted.
(WebCore::SVGLengthValue::valueAsPercentage const): Deleted.
(WebCore::SVGLengthValue::valueInSpecifiedUnits const): Deleted.
(WebCore::SVGLengthValue::setValueInSpecifiedUnits): Deleted.
Canonical link: https://commits.webkit.org/298731@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
