Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bfbc68b18dd0ebcdc60eb92e40b16e341fcdc1ef
https://github.com/WebKit/WebKit/commit/bfbc68b18dd0ebcdc60eb92e40b16e341fcdc1ef
Author: Elliott Williams <e...@apple.com>
Date: 2025-08-15 (Fri, 15 Aug 2025)
Changed paths:
M Tools/Scripts/libraries/webkitapipy/webkitapipy/program.py
M Tools/Scripts/libraries/webkitapipy/webkitapipy/program_unittest.py
M Tools/Scripts/libraries/webkitapipy/webkitapipy/reporter.py
M Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb.py
Log Message:
-----------
[webkitapipy] Fix minor loading and dependency tracking bugs
https://bugs.webkit.org/show_bug.cgi?id=297375
rdar://158270615
Reviewed by Brianna Fan.
* Tools/Scripts/libraries/webkitapipy/webkitapipy/program.py:
- Some libraries in /usr/lib/swift have been replaced with symlinks to
a larger framework, as those swift overlays have been merged. As a
result, the SDK_ALLOWLIST entries for public swift overlays cause
the entire framework to be treated as API. Change loading logic to
ignore symlinks.
- Due to the above change, load from libobjc.A.tbd instead of its
libobjc.tbd symlink.
- Emit load error messages in a format consumable by build systems.
- Add a missing use_input() call on the executable being analyzed,
otherwise audit-spi will not run when only the top-level binary has
been rebuilt.
- Remove unused imports.
* Tools/Scripts/libraries/webkitapipy/webkitapipy/program_unittest.py:
(create_sdk_dir):
(CLITest.test_loads_partial_sdkdb_for_main_file):
(CLITest):
(CLITest.test_does_not_load_merged_swiftoverlays):
(CLITest.test_depends_on_primary_file):
* Tools/Scripts/libraries/webkitapipy/webkitapipy/reporter.py:
- Only print the suggested allowlist entry when a MissingName
diagnostic has been emitted.
(Reporter.has_errors):
(BuildToolReporter.finished):
* Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb.py:
(SDKDB.audit): Only emit at most one diagnostic per item in an allowlist
entry. Previously the "same" diagnostic could be emitted multiple times
when an allowlist entry corresponded to multiple items in the cache
(e.g. a selector implemented in two or more places).
Canonical link: https://commits.webkit.org/298768@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
