Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bd1e24d04518411e0543fc9b37239eb944b2030e
https://github.com/WebKit/WebKit/commit/bd1e24d04518411e0543fc9b37239eb944b2030e
Author: Youenn Fablet <you...@apple.com>
Date: 2025-08-19 (Tue, 19 Aug 2025)
Changed paths:
M Source/WTF/wtf/Logger.cpp
M Source/WTF/wtf/Logger.h
M Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
M Source/WebCore/platform/LogMessages.in
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
Log Message:
-----------
Use forwardable logging in WebRTC WebProcess code
rdar://157117303
https://bugs.webkit.org/show_bug.cgi?id=296701
Reviewed by Eric Carlson and Per Arne Vollan.
We make sure that logs that can be very long are forwarded properly so that
they are not shortened by the default log forwarding mechanism.
We apply this to WebRTC stats, libwebrtc messages and SDP logging.
We introduce a new Logger method so that the above logging can keep being seen
in web inspector.
As a side fix, we no longer convert to hexa log identifiers given we sometimes
log them as pointers, which end up being printed as integers.
We are simply printing them as integers to make it easier to relate the logs.
* Source/WTF/wtf/Logger.cpp:
(WTF::Logger::LogSiteIdentifier::toString const):
(WTF::>::toString):
* Source/WTF/wtf/Logger.h:
(WTF::Logger::toObservers const):
(WTF::Logger::Logger):
(WTF::Logger::log):
(WTF::Logger::sendMessageToObservers):
(WTF::Logger::logVerbose):
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::createOfferSucceeded):
(WebCore::PeerConnectionBackend::createOfferFailed):
(WebCore::PeerConnectionBackend::createAnswerSucceeded):
(WebCore::PeerConnectionBackend::createAnswerFailed):
* Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
* Source/WebCore/platform/LogMessages.in:
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::doReleaseLogging):
Originally-landed-as: 06d8dd827285. rdar://157117303
Canonical link: https://commits.webkit.org/298889@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
