Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fabbe3fe6abdb696c8a430322a2d32565a17e72d
https://github.com/WebKit/WebKit/commit/fabbe3fe6abdb696c8a430322a2d32565a17e72d
Author: Vassili Bykov <v_by...@apple.com>
Date: 2025-08-19 (Tue, 19 Aug 2025)
Changed paths:
M Source/JavaScriptCore/runtime/VM.cpp
Log Message:
-----------
Use a more descriptive error message on an exception check validation failure
https://bugs.webkit.org/show_bug.cgi?id=297604
rdar://158698040
Reviewed by Mark Lam.
An exception check validation failure in
`VM::verifyExceptionCheckNeedIsSatisfied` is
currently triggered by `RELEASE_ASSERT(!m_needExceptionCheck)`. The assert
condition is
invariably false because it appears in an `if` block guarded by
`m_needExceptionCheck`.
Written this way it is not obvious that the failure is not a violation of
internal VM
state consistency. It might even suggest that there used to be logic in this
code,
now missing, that was expected to reset the flag to false.
The patch changes the assert to clarify that the unconditional failure is
intentional
and explicitly state the reason.
Canonical link: https://commits.webkit.org/298929@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
