Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7b22cb5356478c91eb2bdc8b47e393141753dba7
https://github.com/WebKit/WebKit/commit/7b22cb5356478c91eb2bdc8b47e393141753dba7
Author: Alan Baradlay <za...@apple.com>
Date: 2025-08-21 (Thu, 21 Aug 2025)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
Log Message:
-----------
[out-of-flow] ASSERT in LayoutIntegration::LineLayout::paint
https://bugs.webkit.org/show_bug.cgi?id=297724
rdar://157024791
Reviewed by Antti Koivisto.
1. out-of-flow boxes participate first in in-flow layout as if they were
in-flow boxes
where we compute their static position. This static position becomes their final
position when inset (left, right, top, bottom) is auto.
2. as a second step, as we reach the out-of-flow box's containing block
we run layout again and compute the final position (this might just be what we
computed at #1 in case of auto inset)
Now we mark the out-of-flow box dirty at #1 and expect #2 to clear the box by
moving
it to its final position.
However in case of subtree layout where the layout root has an out-of-flow
descendant
while the containing block is an ancestor of the layout root, #2 will never
happen (we bail out of layout before reaching the containing block).
"setNeedsLayout" was added at 254969@main to mimic what legacy line layout did.
However starting from 262470@main, we already move the box at #1 meaning that
#2 does
not need to happen if the box is statically positioned only.
(If the out-of-flow box was not-statically positioned, subtree layout would not
start "below"
its containing block)
* LayoutTests/TestExpectations:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):
Canonical link: https://commits.webkit.org/299021@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
