Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4213214328bfea3f4aeeee954a9ab568f668475e
https://github.com/WebKit/WebKit/commit/4213214328bfea3f4aeeee954a9ab568f668475e
Author: Alan Baradlay <[email protected]>
Date: 2025-08-25 (Mon, 25 Aug 2025)
Changed paths:
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBlockFlow.h
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/RenderView.cpp
M Source/WebCore/rendering/RenderView.h
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderTable.cpp
Log Message:
-----------
[cleanup] De-virtualize RenderBlock's deleteLines() function
https://bugs.webkit.org/show_bug.cgi?id=297832
Reviewed by Antti Koivisto.
1. Only RenderBlockFlow has inline lines.
2. RenderBlockFlow's deleteLines() is essentially invalidating the line layout
path
so it could just diverted to RenderBlockFlow::invalidateLineLayoutPath
3. Rename RenderBlockFlow::invalidateLineLayoutPath to invalidateLineLayout
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::shouldInvalidateLineLayoutAfterChangeFor):
(WebCore::LayoutIntegration::LineLayout::shouldInvalidateLineLayoutAfterContentChange):
(WebCore::LayoutIntegration::LineLayout::shouldInvalidateLineLayoutAfterTreeMutation):
(WebCore::LayoutIntegration::shouldInvalidateLineLayoutPathAfterChangeFor):
Deleted.
(WebCore::LayoutIntegration::LineLayout::shouldInvalidateLineLayoutPathAfterContentChange):
Deleted.
(WebCore::LayoutIntegration::LineLayout::shouldInvalidateLineLayoutPathAfterTreeMutation):
Deleted.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::deleteLines): Deleted.
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::invalidateLineLayout):
(WebCore::RenderBlockFlow::deleteLines): Deleted.
(WebCore::RenderBlockFlow::invalidateLineLayoutPath): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.h:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::invalidateLineLayoutPathOnContentChangeIfNeeded):
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::~RenderView):
(WebCore::RenderView::willBeDestroyed):
* Source/WebCore/rendering/RenderView.h:
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::invalidateLineLayout):
(WebCore::RenderTreeBuilder::move):
(WebCore::RenderTreeBuilder::createAnonymousWrappersForInlineContent):
* Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:
(WebCore::RenderTreeBuilder::Block::detach):
(WebCore::RenderTreeBuilder::Block::dropAnonymousBoxChild):
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::RenderTreeBuilder::Inline::splitFlow):
* Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp:
(WebCore::RenderTreeBuilder::MultiColumn::createFragmentedFlow):
(WebCore::RenderTreeBuilder::MultiColumn::destroyFragmentedFlow):
* Source/WebCore/rendering/updating/RenderTreeBuilderTable.cpp:
(WebCore::RenderTreeBuilder::Table::collapseAndDestroyAnonymousSiblingCells):
Canonical link: https://commits.webkit.org/299109@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
