Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0cc8d008055b8590212df7c71ded13924187a1a5
https://github.com/WebKit/WebKit/commit/0cc8d008055b8590212df7c71ded13924187a1a5
Author: Tim Nguyen <n...@apple.com>
Date: 2025-08-27 (Wed, 27 Aug 2025)
Changed paths:
M Source/WebCore/css/CSSSelector.cpp
M Source/WebCore/css/CSSSelector.h
M Source/WebCore/css/CSSSelectorList.cpp
M Source/WebCore/css/CSSSelectorList.h
M Source/WebCore/css/SelectorChecker.cpp
M Source/WebCore/css/SelectorFilter.cpp
M Source/WebCore/css/StyleRule.cpp
M Source/WebCore/css/parser/CSSParser.cpp
M Source/WebCore/css/parser/CSSSelectorParser.cpp
M Source/WebCore/css/parser/MutableCSSSelector.cpp
M Source/WebCore/css/parser/MutableCSSSelector.h
M Source/WebCore/cssjit/SelectorCompiler.cpp
M Source/WebCore/dom/SelectorQuery.cpp
M Source/WebCore/style/HasSelectorFilter.cpp
M Source/WebCore/style/PageRuleCollector.cpp
M Source/WebCore/style/RuleData.cpp
M Source/WebCore/style/RuleFeature.cpp
M Source/WebCore/style/RuleSet.cpp
M Source/WebCore/style/StyleResolver.cpp
Log Message:
-----------
Rename `tagHistory` in `CSSSelector`
https://bugs.webkit.org/show_bug.cgi?id=297912
rdar://159200563
Reviewed by Antti Koivisto.
The tag history is actually a linked list of simple selectors within a complex
selector. Make that explicit.
m_tagHistory -> m_precedingInComplexSelector
tagHistory() -> precedingInComplexSelector()
setTagHistory() -> setPrecedingInComplexSelector()
appendTagHistory() -> prependInComplexSelector()
appendTagHistoryAsRelative() -> prependInComplexSelectorAsRelative()
prependTagSelector() -> appendTagInComplexSelector()
releaseTagHistory() -> releaseFromComplexSelector()
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::selectorSpecificity):
(WebCore::CSSSelector::specificityForPage const):
(WebCore::CSSSelector::firstInCompound const):
(WebCore::CSSSelector::selectorText const):
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::visitSimpleSelectors const):
* Source/WebCore/css/CSSSelector.h:
(WebCore::CSSSelector::precedingInComplexSelector const):
(WebCore::CSSSelector::isFirstInComplexSelector const):
(WebCore::CSSSelector::isLastInComplexSelector const):
(WebCore::CSSSelector::tagHistory const): Deleted.
(WebCore::CSSSelector::isFirstInTagHistory const): Deleted.
(WebCore::CSSSelector::isLastInTagHistory const): Deleted.
* Source/WebCore/css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::makeCopyingSimpleSelector):
(WebCore::CSSSelectorList::makeCopyingComplexSelector):
(WebCore::CSSSelectorList::listSize const):
(WebCore::forEachTagSelector):
(WebCore::CSSSelectorList::hasOnlyNestingSelector const):
* Source/WebCore/css/CSSSelectorList.h:
(WebCore::CSSSelectorList::const_iterator::operator++):
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively const):
(WebCore::canMatchHoverOrActiveInQuirksMode):
(WebCore::SelectorChecker::determineLinkMatchType):
* Source/WebCore/css/SelectorFilter.cpp:
(WebCore::SelectorFilter::collectSelectorHashes):
* Source/WebCore/css/StyleRule.cpp:
(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount
const):
* Source/WebCore/css/parser/CSSParser.cpp:
(WebCore::CSSParser::parsePageSelector):
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::appendImplicitSelectorPseudoClassScopeIfNeeded):
(WebCore::appendImplicitSelectorNestingParentIfNeeded):
(WebCore::CSSSelectorParser::consumeComplexSelector):
(WebCore::CSSSelectorParser::consumeRelativeScopeSelector):
(WebCore::CSSSelectorParser::consumeCompoundSelector):
(WebCore::CSSSelectorParser::prependTypeSelectorIfNeeded):
(WebCore::CSSSelectorParser::splitCompoundAtImplicitShadowCrossingCombinator):
(WebCore::CSSSelectorParser::containsUnknownWebKitPseudoElements):
* Source/WebCore/css/parser/MutableCSSSelector.cpp:
(WebCore::MutableCSSSelector::MutableCSSSelector):
(WebCore::MutableCSSSelector::~MutableCSSSelector):
(WebCore::MutableCSSSelector::leftmostSimpleSelector const):
(WebCore::MutableCSSSelector::leftmostSimpleSelector):
(WebCore::MutableCSSSelector::hasExplicitNestingParent const):
(WebCore::MutableCSSSelector::hasExplicitPseudoClassScope const):
(WebCore::selectorListMatchesPseudoElement):
(WebCore::MutableCSSSelector::insertInComplexSelector):
(WebCore::MutableCSSSelector::prependInComplexSelector):
(WebCore::MutableCSSSelector::prependInComplexSelectorAsRelative):
(WebCore::MutableCSSSelector::appendTagInComplexSelector):
(WebCore::MutableCSSSelector::releaseFromComplexSelector):
(WebCore::MutableCSSSelector::insertTagHistory): Deleted.
(WebCore::MutableCSSSelector::appendTagHistory): Deleted.
(WebCore::MutableCSSSelector::appendTagHistoryAsRelative): Deleted.
(WebCore::MutableCSSSelector::prependTagSelector): Deleted.
(WebCore::MutableCSSSelector::releaseTagHistory): Deleted.
* Source/WebCore/css/parser/MutableCSSSelector.h:
(WebCore::MutableCSSSelector::precedingInComplexSelector const):
(WebCore::MutableCSSSelector::setPrecedingInComplexSelector):
(WebCore::MutableCSSSelector::clearPrecedingInComplexSelector):
(WebCore::MutableCSSSelector::tagHistory const): Deleted.
(WebCore::MutableCSSSelector::setTagHistory): Deleted.
(WebCore::MutableCSSSelector::clearTagHistory): Deleted.
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::constructFragmentsInternal):
* Source/WebCore/dom/SelectorQuery.cpp:
(WebCore::isSingleTagNameSelector):
(WebCore::isSingleClassNameSelector):
(WebCore::isSingleAttributeExactSelector):
(WebCore::findIdMatchingType):
(WebCore::SelectorDataList::SelectorDataList):
(WebCore::selectorForIdLookup):
(WebCore::filterRootById):
* Source/WebCore/style/HasSelectorFilter.cpp:
(WebCore::Style::HasSelectorFilter::makeKey):
* Source/WebCore/style/PageRuleCollector.cpp:
(WebCore::Style::checkPageSelectorComponents):
* Source/WebCore/style/RuleData.cpp:
(WebCore::Style::computeMatchBasedOnRuleHash):
(WebCore::Style::selectorCanMatchPseudoElement):
(WebCore::Style::determinePropertyAllowlist):
* Source/WebCore/style/RuleFeature.cpp:
(WebCore::Style::computeHasPseudoClassMatchElement):
(WebCore::Style::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):
(WebCore::Style::makePseudoClassInvalidationKey):
* Source/WebCore/style/RuleSet.cpp:
(WebCore::Style::isHostSelectorMatchingInShadowTree):
(WebCore::Style::RuleSet::addRule):
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::viewTransitionSelector):
Canonical link: https://commits.webkit.org/299193@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
