Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2d26a621c91c7305c8e005842a69a0ab1a0bb07c
https://github.com/WebKit/WebKit/commit/2d26a621c91c7305c8e005842a69a0ab1a0bb07c
Author: Elliott Williams <e...@apple.com>
Date: 2025-08-27 (Wed, 27 Aug 2025)
Changed paths:
M Source/WebCore/Configurations/AllowedSPI-legacy.toml
M Source/WebCore/platform/cocoa/RemoteCommandListenerCocoa.mm
M Source/WebCore/platform/mac/MediaRemoteSoftLink.h
M Source/WebCore/platform/mac/MediaRemoteSoftLink.mm
Log Message:
-----------
[WebCore] kMRMediaRemoteCommandInfoPreferredIntervalsKey macro gets the wrong
symbol
https://bugs.webkit.org/show_bug.cgi?id=297802
Reviewed by Eric Carlson.
The macro for accessing kMRMediaRemoteCommandInfoPreferredIntervalsKey
via soft-linking was defined as the wrong getter function. However the
behavior at its use site in RemoteCommandListenerCocoa appears to be
what we intend: We want to specify a default seek amount that gets
passed back to the page via MediaSessionActionDetails, but we do *not*
want to show a label in Now Playing indicating the seek amount, because
the page can override the requested amount.
So, fix the typo but keep using the same key. Now, the code never uses
kMRMediaRemoteCommandInfoPreferredIntervalsKey, so remove its soft-link
entirely.
* Source/WebCore/Configurations/AllowedSPI-legacy.toml:
* Source/WebCore/platform/cocoa/RemoteCommandListenerCocoa.mm:
(WebCore::RemoteCommandListenerCocoa::updateSupportedCommands):
* Source/WebCore/platform/mac/MediaRemoteSoftLink.h:
* Source/WebCore/platform/mac/MediaRemoteSoftLink.mm:
Canonical link: https://commits.webkit.org/299232@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
