Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 297fa9681d782e94d90864f14c9fb874a9fa1123 https://github.com/WebKit/WebKit/commit/297fa9681d782e94d90864f14c9fb874a9fa1123 Author: Eric Carlson <eric.carl...@apple.com> Date: 2025-08-27 (Wed, 27 Aug 2025)
Changed paths: M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations M Source/WebCore/Sources.txt M Source/WebCore/platform/LogMessages.in A Source/WebCore/platform/audio/MediaSessionManagerInterface.cpp M Source/WebCore/platform/audio/MediaSessionManagerInterface.h M Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp M Source/WebCore/platform/audio/PlatformMediaSessionManager.h M Source/WebCore/platform/audio/cocoa/PlatformRawAudioDataCocoa.cpp Log Message: ----------- Move common code from PlatformMediaSessionManager into base class https://bugs.webkit.org/show_bug.cgi?id=297515 rdar://157150064 Reviewed by Andy Estes. Move common code from PlatformMediaSessionManager to MediaSessionManagerInterface. * Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations: * Source/WebCore/Sources.txt: * Source/WebCore/platform/LogMessages.in: * Source/WebCore/platform/audio/MediaSessionManagerInterface.cpp: Copied from Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp. (WebCore::MediaSessionManagerInterface::MediaSessionManagerInterface): (WebCore::MediaSessionManagerInterface::~MediaSessionManagerInterface): (WebCore::indexFromMediaType): (WebCore::MediaSessionManagerInterface::sessionsMatching const): (WebCore::MediaSessionManagerInterface::firstSessionMatching const): (WebCore::MediaSessionManagerInterface::forEachMatchingSession): (WebCore::MediaSessionManagerInterface::forEachSessionInGroup): (WebCore::MediaSessionManagerInterface::forEachSession): (WebCore::MediaSessionManagerInterface::anyOfSessions const): (WebCore::MediaSessionManagerInterface::resetRestrictions): (WebCore::MediaSessionManagerInterface::has const): (WebCore::MediaSessionManagerInterface::activeAudioSessionRequired const): (WebCore::MediaSessionManagerInterface::hasActiveAudioSession const): (WebCore::MediaSessionManagerInterface::canProduceAudio const): (WebCore::MediaSessionManagerInterface::updateNowPlayingInfoIfNecessary): (WebCore::MediaSessionManagerInterface::updateAudioSessionCategoryIfNecessary): (WebCore::MediaSessionManagerInterface::addNowPlayingMetadataObserver): (WebCore::MediaSessionManagerInterface::removeNowPlayingMetadataObserver): (WebCore::MediaSessionManagerInterface::nowPlayingMetadataChanged): (WebCore::MediaSessionManagerInterface::hasActiveNowPlayingSessionInGroup): (WebCore::MediaSessionManagerInterface::enqueueTaskOnMainThread): (WebCore::MediaSessionManagerInterface::beginInterruption): (WebCore::MediaSessionManagerInterface::endInterruption): (WebCore::MediaSessionManagerInterface::applicationWillEnterForeground): (WebCore::MediaSessionManagerInterface::applicationDidEnterBackground): (WebCore::MediaSessionManagerInterface::applicationWillBecomeInactive): (WebCore::MediaSessionManagerInterface::applicationDidBecomeActive): (WebCore::MediaSessionManagerInterface::processWillSuspend): (WebCore::MediaSessionManagerInterface::processDidResume): (WebCore::MediaSessionManagerInterface::stopAllMediaPlaybackForProcess): (WebCore::MediaSessionManagerInterface::mediaPlaybackIsPaused): (WebCore::MediaSessionManagerInterface::pauseAllMediaPlaybackForGroup): (WebCore::MediaSessionManagerInterface::suspendAllMediaPlaybackForGroup): (WebCore::MediaSessionManagerInterface::resumeAllMediaPlaybackForGroup): (WebCore::MediaSessionManagerInterface::suspendAllMediaBufferingForGroup): (WebCore::MediaSessionManagerInterface::resumeAllMediaBufferingForGroup): (WebCore::MediaSessionManagerInterface::addRestriction): (WebCore::MediaSessionManagerInterface::removeRestriction): (WebCore::MediaSessionManagerInterface::restrictions): (WebCore::MediaSessionManagerInterface::sessionWillBeginPlayback): (WebCore::MediaSessionManagerInterface::sessionWillEndPlayback): (WebCore::MediaSessionManagerInterface::sessionStateChanged): (WebCore::MediaSessionManagerInterface::sessionCanProduceAudioChanged): (WebCore::MediaSessionManagerInterface::sessionIsPlayingToWirelessPlaybackTargetChanged): (WebCore::MediaSessionManagerInterface::setIsPlayingToAutomotiveHeadUnit): (WebCore::MediaSessionManagerInterface::setSupportsSpatialAudioPlayback): (WebCore::MediaSessionManagerInterface::addAudioCaptureSource): (WebCore::MediaSessionManagerInterface::removeAudioCaptureSource): (WebCore::MediaSessionManagerInterface::countActiveAudioCaptureSources): (WebCore::MediaSessionManagerInterface::processDidReceiveRemoteControlCommand): (WebCore::MediaSessionManagerInterface::processSystemWillSleep): (WebCore::MediaSessionManagerInterface::processSystemDidWake): (WebCore::MediaSessionManagerInterface::addSession): (WebCore::MediaSessionManagerInterface::removeSession): (WebCore::MediaSessionManagerInterface::hasNoSession const): (WebCore::MediaSessionManagerInterface::computeSupportsSeeking const): (WebCore::MediaSessionManagerInterface::maybeDeactivateAudioSession): (WebCore::MediaSessionManagerInterface::maybeActivateAudioSession): (WebCore::MediaSessionManagerInterface::scheduleUpdateSessionState): (WebCore::MediaSessionManagerInterface::logChannel const): (WebCore::MediaSessionManagerInterface::scheduleStateLog): (WebCore::MediaSessionManagerInterface::dumpSessionStates): (WebCore::MediaSessionManagerInterface::willLog const): * Source/WebCore/platform/audio/MediaSessionManagerInterface.h: (WebCore::MediaSessionManagerInterface::setShouldDeactivateAudioSession): (WebCore::MediaSessionManagerInterface::shouldDeactivateAudioSession): (WebCore::MediaSessionManagerInterface::nowPlayingInfo const): (WebCore::MediaSessionManagerInterface::willIgnoreSystemInterruptions const): (WebCore::MediaSessionManagerInterface::setWillIgnoreSystemInterruptions): (WebCore::MediaSessionManagerInterface::isPlayingToAutomotiveHeadUnit const): (WebCore::MediaSessionManagerInterface::supportsSpatialAudioPlaybackForConfiguration): (WebCore::MediaSessionManagerInterface::audioCaptureSourceStateChanged): (WebCore::MediaSessionManagerInterface::audioCaptureSourceCount const): (WebCore::MediaSessionManagerInterface::processIsSuspended const): (WebCore::MediaSessionManagerInterface::isApplicationInBackground const): (WebCore::MediaSessionManagerInterface::isInterrupted const): (WebCore::MediaSessionManagerInterface::supportsSpatialAudioPlayback): (WebCore::MediaSessionManagerInterface::updateSessionState): * Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::PlatformMediaSessionManager): (WebCore::PlatformMediaSessionManager::addSession): (WebCore::PlatformMediaSessionManager::removeSession): (WebCore::PlatformMediaSessionManager::updateNowPlayingInfoIfNecessary): Deleted. (WebCore::PlatformMediaSessionManager::updateAudioSessionCategoryIfNecessary): Deleted. (WebCore::PlatformMediaSessionManager::~PlatformMediaSessionManager): Deleted. (WebCore::indexFromMediaType): Deleted. (WebCore::PlatformMediaSessionManager::resetRestrictions): Deleted. (WebCore::PlatformMediaSessionManager::has const): Deleted. (WebCore::PlatformMediaSessionManager::activeAudioSessionRequired const): Deleted. (WebCore::PlatformMediaSessionManager::hasActiveAudioSession const): Deleted. (WebCore::PlatformMediaSessionManager::canProduceAudio const): Deleted. (WebCore::PlatformMediaSessionManager::nowPlayingInfo const): Deleted. (WebCore::PlatformMediaSessionManager::count const): Deleted. (WebCore::PlatformMediaSessionManager::countActiveAudioCaptureSources): Deleted. (WebCore::PlatformMediaSessionManager::beginInterruption): Deleted. (WebCore::PlatformMediaSessionManager::endInterruption): Deleted. (WebCore::PlatformMediaSessionManager::hasNoSession const): Deleted. (WebCore::PlatformMediaSessionManager::addRestriction): Deleted. (WebCore::PlatformMediaSessionManager::removeRestriction): Deleted. (WebCore::PlatformMediaSessionManager::restrictions): Deleted. (WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback): Deleted. (WebCore::PlatformMediaSessionManager::sessionWillEndPlayback): Deleted. (WebCore::PlatformMediaSessionManager::sessionStateChanged): Deleted. (WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive): Deleted. (WebCore::PlatformMediaSessionManager::applicationDidBecomeActive): Deleted. (WebCore::PlatformMediaSessionManager::applicationDidEnterBackground): Deleted. (WebCore::PlatformMediaSessionManager::applicationWillEnterForeground): Deleted. (WebCore::PlatformMediaSessionManager::processWillSuspend): Deleted. (WebCore::PlatformMediaSessionManager::processDidResume): Deleted. (WebCore::PlatformMediaSessionManager::setIsPlayingToAutomotiveHeadUnit): Deleted. (WebCore::PlatformMediaSessionManager::setSupportsSpatialAudioPlayback): Deleted. (WebCore::PlatformMediaSessionManager::supportsSpatialAudioPlaybackForConfiguration): Deleted. (WebCore::PlatformMediaSessionManager::sessionIsPlayingToWirelessPlaybackTargetChanged): Deleted. (WebCore::PlatformMediaSessionManager::sessionCanProduceAudioChanged): Deleted. (WebCore::PlatformMediaSessionManager::processDidReceiveRemoteControlCommand): Deleted. (WebCore::PlatformMediaSessionManager::computeSupportsSeeking const): Deleted. (WebCore::PlatformMediaSessionManager::processSystemWillSleep): Deleted. (WebCore::PlatformMediaSessionManager::processSystemDidWake): Deleted. (WebCore::PlatformMediaSessionManager::pauseAllMediaPlaybackForGroup): Deleted. (WebCore::PlatformMediaSessionManager::mediaPlaybackIsPaused): Deleted. (WebCore::PlatformMediaSessionManager::stopAllMediaPlaybackForProcess): Deleted. (WebCore::PlatformMediaSessionManager::suspendAllMediaPlaybackForGroup): Deleted. (WebCore::PlatformMediaSessionManager::resumeAllMediaPlaybackForGroup): Deleted. (WebCore::PlatformMediaSessionManager::suspendAllMediaBufferingForGroup): Deleted. (WebCore::PlatformMediaSessionManager::resumeAllMediaBufferingForGroup): Deleted. (WebCore::PlatformMediaSessionManager::sessionsMatching const): Deleted. (WebCore::PlatformMediaSessionManager::firstSessionMatching const): Deleted. (WebCore::PlatformMediaSessionManager::forEachSessionInGroup): Deleted. (WebCore::PlatformMediaSessionManager::forEachSession): Deleted. (WebCore::PlatformMediaSessionManager::anyOfSessions const): Deleted. (WebCore::PlatformMediaSessionManager::addAudioCaptureSource): Deleted. (WebCore::PlatformMediaSessionManager::removeAudioCaptureSource): Deleted. (WebCore::PlatformMediaSessionManager::scheduleUpdateSessionState): Deleted. (WebCore::PlatformMediaSessionManager::maybeDeactivateAudioSession): Deleted. (WebCore::PlatformMediaSessionManager::maybeActivateAudioSession): Deleted. (WebCore::PlatformMediaSessionManager::addNowPlayingMetadataObserver): Deleted. (WebCore::PlatformMediaSessionManager::removeNowPlayingMetadataObserver): Deleted. (WebCore::PlatformMediaSessionManager::nowPlayingMetadataChanged): Deleted. (WebCore::PlatformMediaSessionManager::hasActiveNowPlayingSessionInGroup): Deleted. (WebCore::PlatformMediaSessionManager::enqueueTaskOnMainThread): Deleted. (WebCore::PlatformMediaSessionManager::logChannel const): Deleted. (WebCore::PlatformMediaSessionManager::scheduleStateLog): Deleted. (WebCore::PlatformMediaSessionManager::dumpSessionStates): Deleted. (WebCore::PlatformMediaSessionManager::willLog const): Deleted. * Source/WebCore/platform/audio/PlatformMediaSessionManager.h: (WebCore::PlatformMediaSessionManager::supportsSpatialAudioPlayback): Deleted. (WebCore::PlatformMediaSessionManager::updateSessionState): Deleted. * Source/WebCore/platform/audio/cocoa/PlatformRawAudioDataCocoa.cpp: Canonical link: https://commits.webkit.org/299233@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes