Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9121909162a9840aa66ed29be94619fc9ab86619
      
https://github.com/WebKit/WebKit/commit/9121909162a9840aa66ed29be94619fc9ab86619
  Author: Mikhail R. Gadelha <mikh...@igalia.com>
  Date:   2025-08-28 (Thu, 28 Aug 2025)

  Changed paths:
    M Source/JavaScriptCore/runtime/Options.cpp

  Log Message:
  -----------
  [JSC] Disable wasm if BBQJIT is not enabled on 32-bit arm
https://bugs.webkit.org/show_bug.cgi?id=297976

Reviewed by Justin Michaud.

This prevents JS tests that don't use wasm but disable JIT from failing
this a check in assertOptionsAreCoherent:

if (useWasm() && !(useWasmIPInt() || useBBQJIT())) {
    coherent = false;
    dataLog("INCOHERENT OPTIONS: at least one of useWasmIPInt, or useBBQJIT 
must be true\n");
}

Since useWasm is enabled by default, if a JS test disables JIT, both
useWasmIPInt (disabled on 32-bit) and useBBQJIT would be false, and the test
would abort even if the test doesn't use wasm at all.

* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::notifyOptionsChanged):

Canonical link: https://commits.webkit.org/299258@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to