Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 779c9d723c65f44c82fc48a5d87b03f22e46f1b6
https://github.com/WebKit/WebKit/commit/779c9d723c65f44c82fc48a5d87b03f22e46f1b6
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2025-09-02 (Tue, 02 Sep 2025)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm
Log Message:
-----------
REGRESSION(298023@main): Newly enabled
TestWebKitAPI.UnifiedPDF.PDFHUDMoveIFrame is broken
https://bugs.webkit.org/show_bug.cgi?id=298259
rdar://159695000
Reviewed by Wenson Hsieh and Aditya Keerthi.
It turns out that in certain configurations, the test is failing with a
tiny diff:
```
11:41:58.050 10802
/Volumes/Data/worker/Apple-Sequoia-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:374
11:41:58.050 10802 Expected equality of these values:
11:41:58.050 10802 frame.origin.x
11:41:58.050 10802 Which is: 13
11:41:58.050 10802 x
11:41:58.050 10802 Which is: 14
11:41:58.050 10802
11:41:58.050 10802
11:41:58.050 10802
11:41:58.050 10802
/Volumes/Data/worker/Apple-Sequoia-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:375
11:41:58.050 10802 Expected equality of these values:
11:41:58.050 10802 frame.origin.y
11:41:58.050 10802 Which is: 39
11:41:58.050 10802 y
11:41:58.050 10802 Which is: 40
```
This patch makes the test robust to this small variance by introducing a
frame origin tolerance that tests can optionally provide when checking
the PDF HUD frame properties. We then adopt a tolerance of 1.0 in
PDFHUDMoveIframe.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::checkFrame):
(TestWebKitAPI::UNIFIED_PDF_TEST):
Canonical link: https://commits.webkit.org/299473@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
