Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 77c558a9da15183e15277c9736703686df70151a
https://github.com/WebKit/WebKit/commit/77c558a9da15183e15277c9736703686df70151a
Author: Joshua Hoffman <josh_hoff...@apple.com>
Date: 2025-09-03 (Wed, 03 Sep 2025)
Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectRareData.h
M Source/WebCore/accessibility/AXTableHelpers.cpp
M Source/WebCore/accessibility/AXTableHelpers.h
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityTableCell.cpp
M Source/WebCore/accessibility/AccessibilityTableCell.h
R Source/WebCore/accessibility/AccessibilityTableRow.cpp
R Source/WebCore/accessibility/AccessibilityTableRow.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
Log Message:
-----------
AX: Collapse AccessibilityTableRow into AccessibilityRenderObject
https://bugs.webkit.org/show_bug.cgi?id=297947
rdar://159245276
Reviewed by Tyler Wilcock.
This moves all of the logic that used to live in AccessibilityTableRow into
AccessibilityRenderObject
and AccessibilityNodeObject, as applicable. This takes advantage of the new
rare data structure.
Notably, type checks to AccessibilityTableRow were replaced by a call to
`isExposedTableRow`, formerly
`isTableRow`. This is equivalent to the old behavior, since that method was
used in type check via the
type traits.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::selectedRows):
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::createObjectFromRenderer):
(WebCore::AXObjectCache::createFromNode):
(WebCore::AXObjectCache::handleChildrenChanged):
(WebCore::isAccessibilityTableRow): Deleted.
(WebCore::isAccessibilityARIAGridRow): Deleted.
* Source/WebCore/accessibility/AXObjectRareData.h:
(WebCore::AXObjectRareData::rowIndex const):
(WebCore::AXObjectRareData::setRowIndex):
* Source/WebCore/accessibility/AXTableHelpers.cpp:
(WebCore::AXTableHelpers::hasRowRole):
(WebCore::AXTableHelpers::isTableRowElement):
* Source/WebCore/accessibility/AXTableHelpers.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::updateOwnedChildrenIfNecessary):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::rowHeaders):
(WebCore::AccessibilityNodeObject::computeCellSlots):
(WebCore::AccessibilityNodeObject::parentTable const):
(WebCore::AccessibilityNodeObject::setRowIndex):
(WebCore::AccessibilityNodeObject::axColumnIndex const):
(WebCore::AccessibilityNodeObject::axRowIndex const):
(WebCore::AccessibilityNodeObject::axRowIndexText const):
(WebCore::AccessibilityNodeObject::disclosedRows):
(WebCore::AccessibilityNodeObject::disclosedByRow const):
(WebCore::AccessibilityNodeObject::isARIAGridRow const):
(WebCore::AccessibilityNodeObject::isARIATreeGridRow const):
(WebCore::AccessibilityNodeObject::isTableRow const):
(WebCore::AccessibilityNodeObject::parentTableIfExposedTableRow const):
(WebCore::AccessibilityNodeObject::updateOwnedChildren):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
(isType): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::isTableComponent):
(WebCore::AccessibilityObject::ignoredByRowAncestor const):
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::needsRareData const):
(WebCore::AccessibilityObject::isAccessibilityNodeObject const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeIsIgnored const):
(WebCore::AccessibilityRenderObject::observableObject const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addChildren):
* Source/WebCore/accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::parentRow const):
* Source/WebCore/accessibility/AccessibilityTableCell.h:
* Source/WebCore/accessibility/AccessibilityTableRow.cpp: Removed.
* Source/WebCore/accessibility/AccessibilityTableRow.h: Removed.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::isAccessibilityNodeObject const):
(WebCore::AXIsolatedObject::isTableRow const):
(WebCore::AXIsolatedObject::parentTableIfExposedTableRow const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateDependentProperties):
(WebCore::convertToPropertyFlag):
(WebCore::createIsolatedObjectData):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Canonical link: https://commits.webkit.org/299517@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
