Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 465721e59955c1f54f1262b1276ba268ee4ae96b
https://github.com/WebKit/WebKit/commit/465721e59955c1f54f1262b1276ba268ee4ae96b
Author: Per Arne Vollan <[email protected]>
Date: 2025-09-04 (Thu, 04 Sep 2025)
Changed paths:
M Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm
M Source/WebKit/NetworkProcess/Downloads/cocoa/WKDownloadProgress.h
M Source/WebKit/NetworkProcess/Downloads/cocoa/WKDownloadProgress.mm
Log Message:
-----------
Service worker downloads are not being saved to Downloads folder
https://bugs.webkit.org/show_bug.cgi?id=298321
rdar://154501503
Reviewed by Chris Dumez and Youenn Fablet.
Service worker downloads have a download data task (m_downloadTask) in the
Download object which is nil.
The current code will prevent these downloads from being saved in the Downloads
folder by disabling the
placeholder feature in WKModernDownloadProgress. Local testing shows that there
is no need to disable
the placeholder feature for Service worker downloads. This patch enables the
placeholder feature for
these downloads. Additionally, the use of WebKit additions is removed for the
modern download progress
feature.
* Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
(WebKit::Download::publishProgress):
* Source/WebKit/NetworkProcess/Downloads/cocoa/WKDownloadProgress.h:
* Source/WebKit/NetworkProcess/Downloads/cocoa/WKDownloadProgress.mm:
(enableModernDownloadProgress):
(activityAccessToken):
(-[WKModernDownloadProgress performCancel]):
(-[WKModernDownloadProgress begin]):
(-[WKModernDownloadProgress resume:]):
(-[WKModernDownloadProgress
initWithDownloadTask:download:URL:useDownloadPlaceholder:resumePlaceholderURL:liveActivityAccessToken:]):
(-[WKModernDownloadProgress startUpdatingDownloadProgress]):
(-[WKModernDownloadProgress didFinish:]):
(-[WKModernDownloadProgress dealloc]):
(-[WKModernDownloadProgress observeValueForKeyPath:ofObject:change:context:]):
Canonical link: https://commits.webkit.org/299564@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
