Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f3bffa9290901749c5b57fc89056dd94a5d75409
      
https://github.com/WebKit/WebKit/commit/f3bffa9290901749c5b57fc89056dd94a5d75409
  Author: Simon Fraser <simon.fra...@apple.com>
  Date:   2025-09-04 (Thu, 04 Sep 2025)

  Changed paths:
    A LayoutTests/fast/box-shadow/inset-shadow-large-spread-expected.html
    A LayoutTests/fast/box-shadow/inset-shadow-large-spread.html
    M Source/WebCore/rendering/BackgroundPainter.cpp

  Log Message:
  -----------
  REGRESSION (291055@main): Buttons with box shadow are broken
https://bugs.webkit.org/show_bug.cgi?id=298341
rdar://159888287

Reviewed by Aditya Keerthi.

The bug occurred with inset shadows that have large spread. The check that
the inner "hole" was empty was failing, because it checked the outer, instead
of the inner shape on the hole BorderShape.

This regressed with the adoption of BorderShape here (291055@main).

* LayoutTests/fast/box-shadow/inset-shadow-large-spread-expected.html: Added.
* LayoutTests/fast/box-shadow/inset-shadow-large-spread.html: Added.
* Source/WebCore/rendering/BackgroundPainter.cpp:
(WebCore::BackgroundPainter::paintBoxShadow const):

Canonical link: https://commits.webkit.org/299603@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to