Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 369438f43a82604e7e9209225d10d7abfb9a5219
https://github.com/WebKit/WebKit/commit/369438f43a82604e7e9209225d10d7abfb9a5219
Author: Megan Gardner <[email protected]>
Date: 2025-09-05 (Fri, 05 Sep 2025)
Changed paths:
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/Editor.h
M Source/WebCore/editing/EditorCommand.cpp
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebKit/WebProcess/WebPage/FindController.cpp
M Source/WebKit/WebProcess/WebPage/FindController.h
Log Message:
-----------
[macOS] -webkit-user-select: none disables searching in Safari.
https://bugs.webkit.org/show_bug.cgi?id=298345
rdar://8081660
Reviewed by Aditya Keerthi.
Follow up work for mac in relation to 298785@main.
We do not have the fallback range available in the same
way on macOS as we did on iOS. In order to have a similar
solution for creating an indicator based on the range,
we need to pass that range back to the FindController so
that it can be used in the fallback case.
We also need to be checking the normalized range,
as the regular range will return the uncollapsed version,
and that will not send us down the fallback path.
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::findString):
* Source/WebCore/editing/Editor.h:
* Source/WebCore/editing/EditorCommand.cpp:
(WebCore::executeFindString):
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::find const):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::findString):
* Source/WebCore/page/Page.h:
* Source/WebKit/WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::frameWithSelection):
(WebKit::FindController::findString):
(WebKit::FindController::updateFindIndicator):
* Source/WebKit/WebProcess/WebPage/FindController.h:
Canonical link: https://commits.webkit.org/299624@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
