Title: [113266] trunk
Revision
113266
Author
[email protected]
Date
2012-04-04 17:03:04 -0700 (Wed, 04 Apr 2012)

Log Message

RealtimeAnalyserNode should support smaller analysis sizes
https://bugs.webkit.org/show_bug.cgi?id=83215

Source/WebCore:

Reviewed by Kenneth Russell.

RealtimeAnalyserNode analysis size currently goes no lower than 128.
It is useful to support lower power-of-two sizes.
Decrease this limit to 32.

Updated webaudio/realtimeanalyser-fft-sizing-expected.txt

* Modules/webaudio/RealtimeAnalyser.cpp:
(WebCore):

LayoutTests:

Reviewed by Kenneth Russell.

* webaudio/realtimeanalyser-fft-sizing-expected.txt:
* webaudio/realtimeanalyser-fft-sizing.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (113265 => 113266)


--- trunk/LayoutTests/ChangeLog	2012-04-05 00:00:31 UTC (rev 113265)
+++ trunk/LayoutTests/ChangeLog	2012-04-05 00:03:04 UTC (rev 113266)
@@ -1,3 +1,13 @@
+2012-04-04  Chris Rogers  <[email protected]>
+
+        RealtimeAnalyserNode should support smaller analysis sizes
+        https://bugs.webkit.org/show_bug.cgi?id=83215
+
+        Reviewed by Kenneth Russell.
+
+        * webaudio/realtimeanalyser-fft-sizing-expected.txt:
+        * webaudio/realtimeanalyser-fft-sizing.html:
+
 2012-04-04  David Barr  <[email protected]>
 
         Unify and modernize fast/css/{outline,background}-currentcolor.html

Modified: trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing-expected.txt (113265 => 113266)


--- trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing-expected.txt	2012-04-05 00:00:31 UTC (rev 113265)
+++ trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing-expected.txt	2012-04-05 00:03:04 UTC (rev 113266)
@@ -13,9 +13,9 @@
 PASS Exception thrown for illegal fftSize 9.
 PASS Exception thrown for illegal fftSize 16.
 PASS Exception thrown for illegal fftSize 17.
-PASS Exception thrown for illegal fftSize 32.
+PASS Successfully set legal fftSize 32.
 PASS Exception thrown for illegal fftSize 33.
-PASS Exception thrown for illegal fftSize 64.
+PASS Successfully set legal fftSize 64.
 PASS Exception thrown for illegal fftSize 65.
 PASS Successfully set legal fftSize 128.
 PASS Exception thrown for illegal fftSize 129.

Modified: trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing.html (113265 => 113266)


--- trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing.html	2012-04-05 00:00:31 UTC (rev 113265)
+++ trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing.html	2012-04-05 00:03:04 UTC (rev 113266)
@@ -39,7 +39,7 @@
 doTest(0, true);
 doTest(1, true);
 for (var i = 2; i <= 0x20000; i *= 2) {
-	if (i >= 128 && i <= 2048)
+	if (i >= 32 && i <= 2048)
         doTest(i, false);
     else
         doTest(i, true);

Modified: trunk/Source/WebCore/ChangeLog (113265 => 113266)


--- trunk/Source/WebCore/ChangeLog	2012-04-05 00:00:31 UTC (rev 113265)
+++ trunk/Source/WebCore/ChangeLog	2012-04-05 00:03:04 UTC (rev 113266)
@@ -1,3 +1,19 @@
+2012-04-04  Chris Rogers  <[email protected]>
+
+        RealtimeAnalyserNode should support smaller analysis sizes
+        https://bugs.webkit.org/show_bug.cgi?id=83215
+
+        Reviewed by Kenneth Russell.
+        
+        RealtimeAnalyserNode analysis size currently goes no lower than 128.
+        It is useful to support lower power-of-two sizes.
+        Decrease this limit to 32.
+
+        Updated webaudio/realtimeanalyser-fft-sizing-expected.txt
+
+        * Modules/webaudio/RealtimeAnalyser.cpp:
+        (WebCore):
+
 2012-04-04  Tony Chang  <[email protected]>
 
         CSS transitions should work on the flex property

Modified: trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp (113265 => 113266)


--- trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp	2012-04-05 00:00:31 UTC (rev 113265)
+++ trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp	2012-04-05 00:03:04 UTC (rev 113266)
@@ -51,7 +51,7 @@
 
 const unsigned RealtimeAnalyser::DefaultFFTSize = 2048;
 // All FFT implementations are expected to handle power-of-two sizes MinFFTSize <= size <= MaxFFTSize.
-const unsigned RealtimeAnalyser::MinFFTSize = 128;
+const unsigned RealtimeAnalyser::MinFFTSize = 32;
 const unsigned RealtimeAnalyser::MaxFFTSize = 2048;
 const unsigned RealtimeAnalyser::InputBufferSize = RealtimeAnalyser::MaxFFTSize * 2;
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to