Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8896aad97fa3f274318189a550b3e0abb25780ba
https://github.com/WebKit/WebKit/commit/8896aad97fa3f274318189a550b3e0abb25780ba
Author: Lily Spiniolas <[email protected]>
Date: 2025-09-08 (Mon, 08 Sep 2025)
Changed paths:
A LayoutTests/fast/forms/range/slider-repaint-vertical-rl-expected.txt
A LayoutTests/fast/forms/range/slider-repaint-vertical-rl.html
A
LayoutTests/platform/ios-18/fast/forms/range/slider-repaint-vertical-rl-expected.txt
M LayoutTests/platform/ios/TestExpectations
A
LayoutTests/platform/ios/fast/forms/range/slider-repaint-vertical-rl-expected.txt
A
LayoutTests/platform/mac-sequoia/fast/forms/range/slider-repaint-vertical-rl-expected.txt
A
LayoutTests/platform/mac-sonoma/fast/forms/range/slider-repaint-vertical-rl-expected.txt
A
LayoutTests/platform/mac/fast/forms/range/slider-repaint-vertical-rl-expected.txt
M Source/WebCore/html/shadow/SliderThumbElement.cpp
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
M Source/WebCore/rendering/mac/RenderThemeMac.h
M Source/WebCore/rendering/mac/RenderThemeMac.mm
Log Message:
-----------
Repaint rects for slider controls are incorrect for RTL vertical block
writing modes
https://bugs.webkit.org/show_bug.cgi?id=297821
rdar://158567821
Reviewed by Aditya Keerthi.
For slider elements with RTL vertical block writing modes, repaint the input
before layout to avoid an issue where the repaint rect is positioned
incorrectly.
The issue is suspected to stem from the following bug
https://webkit.org/b/70762.
Move `RenderThemeMac::adjustRepaintRect` to
`RenderThemeCocoa::adjustRepaintRect`
so that the repaint rect is properly inflated to include the thumb's shadow.
* LayoutTests/fast/forms/range/slider-repaint-vertical-rl-expected.txt: Added.
* LayoutTests/fast/forms/range/slider-repaint-vertical-rl.html: Added.
*
LayoutTests/platform/ios-18/fast/forms/range/slider-repaint-vertical-rl-expected.txt:
Added.
* LayoutTests/platform/ios/TestExpectations:
*
LayoutTests/platform/ios/fast/forms/range/slider-repaint-vertical-rl-expected.txt:
Added.
*
LayoutTests/platform/mac-sequoia/fast/forms/range/slider-repaint-vertical-rl-expected.txt:
Added.
*
LayoutTests/platform/mac-sonoma/fast/forms/range/slider-repaint-vertical-rl-expected.txt:
Added.
*
LayoutTests/platform/mac/fast/forms/range/slider-repaint-vertical-rl-expected.txt:
Added.
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint):
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::adjustRepaintRect):
* Source/WebCore/rendering/mac/RenderThemeMac.h:
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect): Deleted.
Canonical link: https://commits.webkit.org/299690@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
