Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 31979809001642aa1d3290c3dd30be0be3b0f738
https://github.com/WebKit/WebKit/commit/31979809001642aa1d3290c3dd30be0be3b0f738
Author: Elliott Williams <[email protected]>
Date: 2025-09-08 (Mon, 08 Sep 2025)
Changed paths:
M Source/JavaScriptCore/Configurations/AllowedSPI-legacy.toml
M Source/JavaScriptCore/Configurations/AllowedSPI.toml
M Source/WebCore/Configurations/AllowedSPI-legacy.toml
M Source/WebCore/Configurations/AllowedSPI.toml
M Source/WebKit/Configurations/AllowedSPI-legacy.toml
M Source/WebKit/Configurations/AllowedSPI.toml
M Source/WebKitLegacy/mac/Configurations/AllowedSPI-legacy.toml
M Tools/Scripts/libraries/webkitapipy/webkitapipy/allow.py
M Tools/Scripts/libraries/webkitapipy/webkitapipy/allow_unittest.py
M Tools/Scripts/libraries/webkitapipy/webkitapipy/reporter.py
M Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb_unittest.py
Log Message:
-----------
[SPI checking] Use C-style symbol names in allowlists
https://bugs.webkit.org/show_bug.cgi?id=298462
rdar://159957130
Reviewed by Brianna Fan.
Instead of writing the raw symbol name in allowlists, use the C
namespace rules, i.e. remove the leading underscore from the symbol
name. This has the nice benefit of making a symbol's spelling in an
allowlist match its spelling in code.
This is a cosmetic detail. Internally, webkitapipy continues to track
symbols using their raw names, so the only change is to allowlist
parsing and reporting logic.
* Source/JavaScriptCore/Configurations/AllowedSPI-legacy.toml:
* Source/JavaScriptCore/Configurations/AllowedSPI.toml:
* Source/WebCore/Configurations/AllowedSPI-legacy.toml:
* Source/WebCore/Configurations/AllowedSPI.toml:
* Source/WebKit/Configurations/AllowedSPI-legacy.toml:
* Source/WebKit/Configurations/AllowedSPI.toml:
* Source/WebKitLegacy/mac/Configurations/AllowedSPI-legacy.toml:
* Tools/Scripts/libraries/webkitapipy/webkitapipy/allow.py:
(AllowList.from_dict):
* Tools/Scripts/libraries/webkitapipy/webkitapipy/allow_unittest.py:
* Tools/Scripts/libraries/webkitapipy/webkitapipy/reporter.py:
(Reporter.demangle_name): Added. Shared function to turn a diagnostic's
"name" field into something human-readable. In the future, we may
choose to demangle further, to turn Swift and C++ symbols into
human-readable names.
(TSVReporter.format_diagnostic):
(BuildToolReporter.format_diagnostic):
* Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb_unittest.py:
Canonical link: https://commits.webkit.org/299714@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
