Title: [113275] trunk/LayoutTests
Revision
113275
Author
[email protected]
Date
2012-04-04 19:07:27 -0700 (Wed, 04 Apr 2012)

Log Message

Update a layout test, adding a case for traversing a ShadowRoot which does not have any children.
https://bugs.webkit.org/show_bug.cgi?id=82593

Reviewed by Dimitri Glazkov.

Prior to r113125, if we traverse a ShadowRoot which does not have any children,
it caused an assertion failure on debug build. r113125 fixed this issue implicitly.
Adds a test case for that to catch a future regression.

* fast/dom/shadow/focus-navigation-expected.html:
* fast/dom/shadow/focus-navigation.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (113274 => 113275)


--- trunk/LayoutTests/ChangeLog	2012-04-05 01:57:19 UTC (rev 113274)
+++ trunk/LayoutTests/ChangeLog	2012-04-05 02:07:27 UTC (rev 113275)
@@ -1,3 +1,17 @@
+2012-04-04  Hayato Ito  <[email protected]>
+
+        Update a layout test, adding a case for traversing a ShadowRoot which does not have any children.
+        https://bugs.webkit.org/show_bug.cgi?id=82593
+
+        Reviewed by Dimitri Glazkov.
+
+        Prior to r113125, if we traverse a ShadowRoot which does not have any children,
+        it caused an assertion failure on debug build. r113125 fixed this issue implicitly.
+        Adds a test case for that to catch a future regression.
+
+        * fast/dom/shadow/focus-navigation-expected.html:
+        * fast/dom/shadow/focus-navigation.html:
+
 2012-04-04  Oliver Hunt  <[email protected]>
 
         Parser fails to revert some state after parsing _expression_ and object literals.

Modified: trunk/LayoutTests/fast/dom/shadow/focus-navigation-expected.txt (113274 => 113275)


--- trunk/LayoutTests/fast/dom/shadow/focus-navigation-expected.txt	2012-04-05 01:57:19 UTC (rev 113274)
+++ trunk/LayoutTests/fast/dom/shadow/focus-navigation-expected.txt	2012-04-05 02:07:27 UTC (rev 113275)
@@ -46,10 +46,18 @@
 PASS
 Should move from input-C-0 to input-D-0 in forward
 PASS
-Should move from input-D-0 to input-A-1 in forward
+Should move from input-D-0 to host-D in forward
 PASS
-Should move from input-A-1 to input-D-0 in backward
+Should move from host-D to input-E-0 in forward
 PASS
+Should move from input-E-0 to input-A-1 in forward
+PASS
+Should move from input-A-1 to input-E-0 in backward
+PASS
+Should move from input-E-0 to host-D in backward
+PASS
+Should move from host-D to input-D-0 in backward
+PASS
 Should move from input-D-0 to input-C-0 in backward
 PASS
 Should move from input-C-0 to input-B-0 in backward
@@ -96,7 +104,7 @@
 PASS
 Should move from input-B-1 to input-A-1 in backward
 PASS
-Should move from input-A-1 to input-D-0 in backward
+Should move from input-A-1 to input-E-0 in backward
 PASS
 Test finished.
 
@@ -104,3 +112,4 @@
 
 
 
+

Modified: trunk/LayoutTests/fast/dom/shadow/focus-navigation.html (113274 => 113275)


--- trunk/LayoutTests/fast/dom/shadow/focus-navigation.html	2012-04-05 01:57:19 UTC (rev 113274)
+++ trunk/LayoutTests/fast/dom/shadow/focus-navigation.html	2012-04-05 02:07:27 UTC (rev 113275)
@@ -50,8 +50,11 @@
                   createDOM('div', {'id': 'host-C', 'tabindex': -1},
                             createShadowRoot(
                                 createDOM('input', {'tabindex': -1}))),
-                  createDOM('input', {'id': 'input-D-0', 'tabindex': 0})));
-
+                  createDOM('input', {'id': 'input-D-0', 'tabindex': 0}),
+                  createDOM('div', {},
+                            createDOM('div', {'id': 'host-D', 'tabindex': 0},
+                                      createShadowRoot())),
+                  createDOM('input', {'id': 'input-E-0', 'tabindex': 0})));
     parent.offsetLeft;
 }
 
@@ -117,6 +120,8 @@
 
         // A non-focusable shadow host (id=host-C), which does not have focusable elements, should be skipped entirely.
         'input-D-0',
+        'host-D',
+        'input-E-0',
 
         // Wraps to the first element in the outermost focus scope.
         'input-A-1',
@@ -125,6 +130,8 @@
 
     elementsNavigatedInBackward = [
         'input-A-1',
+        'input-E-0',
+        'host-D',
         'input-D-0',
         'input-C-0',
         'input-B-0',
@@ -163,7 +170,7 @@
         'input-A-1',
 
         // Wraps to the last element in the outermost focus scope.
-        'input-D-0',
+        'input-E-0',
     ];
 
     testFocusNavigationFowrad(elementsNavigatedInForward);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to