Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b7606dbaa7ea229f5fdd279d6b429995846b66b3
https://github.com/WebKit/WebKit/commit/b7606dbaa7ea229f5fdd279d6b429995846b66b3
Author: Frédéric Wang <[email protected]>
Date: 2025-09-09 (Tue, 09 Sep 2025)
Changed paths:
M Source/WebKit/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations
M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
Log Message:
-----------
Adopt more smart pointers in WebProcessPoolCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=296680
Reviewed by Darin Adler.
The remaining RetainPtrCtorAdoptChecker in this file is fixed. A couple
of false positive warnings are turned off by tagging global NSString*
variables as const and using *Singleton wrapper functions for NSApplication
and dispatch_queue_t. Other warnings for ObjectiveC object are left for now,
they could be handled similarly, or fixed by the checker.
* Source/WebKit/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations:
Remove WebProcessPoolCocoa.mm.
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: Mark some NSString*
keys as const.
(WebKit::globalQueueSingleton): New helper function to turn off warnings with
dispatch_get_global_queue().
(WebKit::mainQueueSingleton): Ditto for dispatch_get_main_queue().
(WebKit::NSAppSingleton): Same for NSApp.
(WebKit::WebProcessPool::setMediaAccessibilityPreferences): Fix a
RetainPtrCtorAdoptChecker error.
(WebKit::WebProcessPool::platformInitialize): Fix UnretainedCallArgsChecker
erros.
(WebKit::WebProcessPool::platformInitializeWebProcess): Ditto.
(WebKit::WebProcessPool::initializeHardwareKeyboardAvailability): Ditto.
(WebKit::WebProcessPool::startObservingPreferenceChanges): Ditto.
(WebKit::WebProcessPool::registerNotificationObservers): Ditto.
(WebKit::WebProcessPool::clearPermanentCredentialsForProtectionSpace): Ditto.
(WebKit::WebProcessPool::registerAssetFonts): Ditto.
Canonical link: https://commits.webkit.org/299748@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
