Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8062f3de28baf85ae278ce06232a7c7a2aac7c80
https://github.com/WebKit/WebKit/commit/8062f3de28baf85ae278ce06232a7c7a2aac7c80
Author: Jer Noble <[email protected]>
Date: 2025-09-09 (Tue, 09 Sep 2025)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/bindings/js/JSCustomElementInterface.cpp
M Source/WebCore/bindings/js/JSWindowProxy.cpp
M Source/WebCore/dom/ChildListMutationScope.h
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/DocumentFullscreen.cpp
M Source/WebCore/dom/DocumentFullscreen.h
M Source/WebCore/dom/DocumentInlines.h
M Source/WebCore/dom/MutationObserver.h
M Source/WebCore/dom/MutationObserverInterestGroup.h
A Source/WebCore/dom/MutationObserverOptions.h
M Source/WebCore/dom/XMLDocument.h
M Source/WebCore/html/HTMLDocument.h
M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
M Source/WebCore/html/canvas/WebGLRenderingContext.cpp
M Source/WebCore/inspector/InspectorInstrumentation.cpp
M Source/WebCore/inspector/InspectorInstrumentation.h
M Source/WebCore/loader/DocumentThreadableLoader.cpp
M Source/WebCore/style/StyleExtractorConverter.h
M Source/WebCore/xml/DOMParser.cpp
M Source/WebKitLegacy/mac/DOM/DOMUtility.mm
Log Message:
-----------
[Build Speed] Remove DocumentInlines.h from all non-Inlines.h headers
rdar://160166530
https://bugs.webkit.org/show_bug.cgi?id=298578
Reviewed by Chris Dumez.
Prior to this patch, there were 7 instances of including Document.h in
non-Inlines.h headers, the
third largest such header in the WebCore project.
Many of the uses of DocumentInlines.h was to enable using
MutationObserverOptions, so this enum
and OptionSet were pulled into its own (inexpensive) header so it could be used
directly in Document.h.
Other uses included going from Document to Frame to Page in
InspectorInstrumentation, but since the
entry points passing Page were non-inline, there was no benefit to inlining
these functions.
DocumentFullscreen.h needed DocumentInlines.h to implement a private, inline
nested class; the entire class
was moved into the implementation file. A private page() accessor was moved to
the implementation file as well.
Other files included DocumentInlines.h but did not need to, including
HTMLDocument.h and XMLDocument.h.
After this patch, no uses of Document.h in non-Inlines.h headers remain.
* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/JSCustomElementInterface.cpp:
* Source/WebCore/bindings/js/JSWindowProxy.cpp:
* Source/WebCore/dom/ChildListMutationScope.h:
* Source/WebCore/dom/Document.h:
(WebCore::Document::hasMutationObserversOfType const):
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::page const):
* Source/WebCore/dom/DocumentFullscreen.h:
* Source/WebCore/dom/DocumentInlines.h:
(WebCore::Document::hasMutationObserversOfType const): Deleted.
* Source/WebCore/dom/MutationObserver.h:
* Source/WebCore/dom/MutationObserverInterestGroup.h:
* Source/WebCore/dom/MutationObserverOptions.h:
* Source/WebCore/dom/XMLDocument.h:
* Source/WebCore/html/HTMLDocument.h:
* Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
* Source/WebCore/inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::instrumentingAgents):
* Source/WebCore/inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didAddOrRemoveScrollbars):
(WebCore::InspectorInstrumentation::didReceiveThreadableLoaderResponse):
* Source/WebCore/loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveResponse):
* Source/WebCore/style/StyleExtractorConverter.h:
* Source/WebCore/xml/DOMParser.cpp:
* Source/WebKitLegacy/mac/DOM/DOMUtility.mm:
Canonical link: https://commits.webkit.org/299782@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
