Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a05bb82b74278830f51aea6945abf5e9672a9ee7
https://github.com/WebKit/WebKit/commit/a05bb82b74278830f51aea6945abf5e9672a9ee7
Author: Ruthvik Konda <rkon...@apple.com>
Date: 2025-09-12 (Fri, 12 Sep 2025)
Changed paths:
M
LayoutTests/http/tests/webgpu/webgpu/web_platform/copyToTexture/ImageData-expected.txt
M
LayoutTests/http/tests/webgpu/webgpu/web_platform/copyToTexture/image-expected.txt
M
LayoutTests/http/tests/webgpu/webgpu/web_platform/copyToTexture/image_file-expected.txt
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/Modules/WebGPU/GPUQueue.cpp
Log Message:
-----------
[WebGPU] webgpu:web_platform,copyToTexture,ImageData:* is failing
https://bugs.webkit.org/show_bug.cgi?id=298141
rdar://159491345
Reviewed by Mike Wyrzykowski.
Currently, when copying external image bytes to the destination texture,
we use the same behavior for the Bgra8unorm and Bgra8unormSRGB texture formats
that we do for the Rgba8unorm formats. This is incorrect. We should be
performing a conversion here for the appropriate channels. This fix
does that.
Additionally, getImageBytesFromImageBuffer() should never do pixel format
conversion. It should
just provide the RGBA8 bytes to copyToDestinationFormat(), and then
copyToDestinationFormat() should be doing all pixel format conversions.
These changes also fixed various subtest cases in image_file.html and image.html
so expected.txt files were updated. Lastly, we update mac-wk2
TestExpectations to run all web_platform/copyToTexture tests so we can catch
subtest regressions.
*
LayoutTests/http/tests/webgpu/webgpu/web_platform/copyToTexture/ImageData-expected.txt:
*
LayoutTests/http/tests/webgpu/webgpu/web_platform/copyToTexture/image-expected.txt:
*
LayoutTests/http/tests/webgpu/webgpu/web_platform/copyToTexture/image_file-expected.txt:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/Modules/WebGPU/GPUQueue.cpp:
(WebCore::getImageBytesFromImageBuffer):
(WebCore::imageBytesForSource):
(WebCore::copyToDestinationFormat):
Canonical link: https://commits.webkit.org/299914@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
