Title: [113292] trunk/LayoutTests
Revision
113292
Author
[email protected]
Date
2012-04-04 22:17:15 -0700 (Wed, 04 Apr 2012)

Log Message

Layout Test http/tests/websocket/tests/hybi/workers/worker-reload.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=83173

Reviewed by David Levin.

Try to deflake the test by
- decreasing the number of reloads in the test, and
- changing the URL of WebSocket to silence random console messages.

* http/tests/websocket/tests/hybi/workers/resources/worker-reload-iframe.html:
Reloading 100 times seemed too much, as Chromium debug bots frequently time out.
* http/tests/websocket/tests/hybi/workers/resources/worker-reload.js:
Use a real URL to avoid random console messages.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (113291 => 113292)


--- trunk/LayoutTests/ChangeLog	2012-04-05 05:15:10 UTC (rev 113291)
+++ trunk/LayoutTests/ChangeLog	2012-04-05 05:17:15 UTC (rev 113292)
@@ -1,3 +1,19 @@
+2012-04-04  Yuta Kitamura  <[email protected]>
+
+        Layout Test http/tests/websocket/tests/hybi/workers/worker-reload.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=83173
+
+        Reviewed by David Levin.
+
+        Try to deflake the test by
+        - decreasing the number of reloads in the test, and
+        - changing the URL of WebSocket to silence random console messages.
+
+        * http/tests/websocket/tests/hybi/workers/resources/worker-reload-iframe.html:
+        Reloading 100 times seemed too much, as Chromium debug bots frequently time out.
+        * http/tests/websocket/tests/hybi/workers/resources/worker-reload.js:
+        Use a real URL to avoid random console messages.
+
 2012-04-04  Adam Barth  <[email protected]>
 
         XSSAuditor doesn't catch injected srcdoc attributes

Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/workers/resources/worker-reload-iframe.html (113291 => 113292)


--- trunk/LayoutTests/http/tests/websocket/tests/hybi/workers/resources/worker-reload-iframe.html	2012-04-05 05:15:10 UTC (rev 113291)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/workers/resources/worker-reload-iframe.html	2012-04-05 05:17:15 UTC (rev 113292)
@@ -9,7 +9,7 @@
 if (match)
     repeat = parseInt(match[1]);
 
-if (repeat === 100) {
+if (repeat === 20) {
     document.getElementById("result").innerHTML = "Done.";
     parent.document.iframeFinished();
 } else {

Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/workers/resources/worker-reload.js (113291 => 113292)


--- trunk/LayoutTests/http/tests/websocket/tests/hybi/workers/resources/worker-reload.js	2012-04-05 05:15:10 UTC (rev 113291)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/workers/resources/worker-reload.js	2012-04-05 05:17:15 UTC (rev 113292)
@@ -1 +1 @@
-new WebSocket('ws://localhost:12345');
+new WebSocket('ws://localhost:8880/websocket/tests/hybi/workers/resources/echo');
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to