Title: [113300] trunk
- Revision
- 113300
- Author
- [email protected]
- Date
- 2012-04-05 01:47:21 -0700 (Thu, 05 Apr 2012)
Log Message
[EFL] keycode translation is wrong for function keys
https://bugs.webkit.org/show_bug.cgi?id=82738
Source/WebCore:
This patch fixes keycode translation for function keys.
Patch by Sudarsana Nagineni <[email protected]> on 2012-04-05
Reviewed by Philippe Normand.
Test: fast/events/keydown-function-keys.html
* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::createWindowsKeyMap):
LayoutTests:
Unskip fast/events/keydown-function-keys.html
Patch by Sudarsana Nagineni <[email protected]> on 2012-04-05
Reviewed by Philippe Normand.
* platform/efl/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (113299 => 113300)
--- trunk/LayoutTests/ChangeLog 2012-04-05 08:18:07 UTC (rev 113299)
+++ trunk/LayoutTests/ChangeLog 2012-04-05 08:47:21 UTC (rev 113300)
@@ -1,3 +1,14 @@
+2012-04-05 Sudarsana Nagineni <[email protected]>
+
+ [EFL] keycode translation is wrong for function keys
+ https://bugs.webkit.org/show_bug.cgi?id=82738
+
+ Unskip fast/events/keydown-function-keys.html
+
+ Reviewed by Philippe Normand.
+
+ * platform/efl/Skipped:
+
2012-04-01 Nikolas Zimmermann <[email protected]>
Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests
Modified: trunk/LayoutTests/platform/efl/Skipped (113299 => 113300)
--- trunk/LayoutTests/platform/efl/Skipped 2012-04-05 08:18:07 UTC (rev 113299)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-04-05 08:47:21 UTC (rev 113300)
@@ -1319,7 +1319,6 @@
fast/events/js-keyboard-event-creation.html
fast/events/key-events-in-input-button.html
fast/events/key-events-in-input-text.html
-fast/events/keydown-function-keys.html
fast/events/keydown-numpad-keys.html
fast/events/onsearch-enter.html
fast/events/option-tab.html
Modified: trunk/Source/WebCore/ChangeLog (113299 => 113300)
--- trunk/Source/WebCore/ChangeLog 2012-04-05 08:18:07 UTC (rev 113299)
+++ trunk/Source/WebCore/ChangeLog 2012-04-05 08:47:21 UTC (rev 113300)
@@ -1,3 +1,17 @@
+2012-04-05 Sudarsana Nagineni <[email protected]>
+
+ [EFL] keycode translation is wrong for function keys
+ https://bugs.webkit.org/show_bug.cgi?id=82738
+
+ This patch fixes keycode translation for function keys.
+
+ Reviewed by Philippe Normand.
+
+ Test: fast/events/keydown-function-keys.html
+
+ * platform/efl/EflKeyboardUtilities.cpp:
+ (WebCore::createWindowsKeyMap):
+
2012-04-01 Nikolas Zimmermann <[email protected]>
Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests
Modified: trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp (113299 => 113300)
--- trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp 2012-04-05 08:18:07 UTC (rev 113299)
+++ trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp 2012-04-05 08:47:21 UTC (rev 113300)
@@ -163,7 +163,7 @@
// Set F_XX keys to the windowsKeyMap.
for (unsigned int i = 1; i < 25; i++) {
String key = "F" + String::number(i);
- windowsKeyMap().set(key, VK_F1 + i);
+ windowsKeyMap().set(key, VK_F1 + i - 1);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
