Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 574f267b96d7dbb17f0b31fed176da84d293edfa
https://github.com/WebKit/WebKit/commit/574f267b96d7dbb17f0b31fed176da84d293edfa
Author: Alan Baradlay <za...@apple.com>
Date: 2025-09-15 (Mon, 15 Sep 2025)
Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLine.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
M
Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp
Log Message:
-----------
[cleanup] Line class should have dedicated append functions for each content
type
https://bugs.webkit.org/show_bug.cgi?id=298823
Reviewed by Antti Koivisto.
This is in preparation for expanding the 'append' parameter list to support
shaping boundary bit. It's text content specific and yet we would need to add
it to the generic append function (which already has one specific parameter).
* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::appendText):
(WebCore::Layout::Line::TrimmableTrailingContent::addFullyTrimmableContent):
(WebCore::Layout::Line::append): Deleted.
(WebCore::Layout::Line::appendTextContent): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLine.h:
(WebCore::Layout::Line::setContentNeedsBidiReordering):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::placeInlineAndFloatContent):
(WebCore::Layout::LineBuilder::commitCanidateContent):
(WebCore::Layout::LineBuilder::processLineBreakingResult):
(WebCore::Layout::LineBuilder::commitPartialContent): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:
* Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp:
(WebCore::Layout::consumeTrailingLineBreakIfApplicable):
(WebCore::Layout::TextOnlySimpleLineBuilder::placeNonWrappingInlineTextContent):
Canonical link: https://commits.webkit.org/299980@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
