Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ddb0937139f40dab201e99762987ac50dbf39c42
https://github.com/WebKit/WebKit/commit/ddb0937139f40dab201e99762987ac50dbf39c42
Author: Tyler Wilcock <[email protected]>
Date: 2025-09-15 (Mon, 15 Sep 2025)
Changed paths:
M
LayoutTests/accessibility/mac/press-action-not-exposed-for-event-delegation-expected.txt
M
LayoutTests/accessibility/mac/press-action-not-exposed-for-event-delegation.html
A
LayoutTests/accessibility/mac/supports-press-action-with-dynamic-cursor-type-expected.txt
A
LayoutTests/accessibility/mac/supports-press-action-with-dynamic-cursor-type.html
M LayoutTests/accessibility/onclick-handlers.html
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXNotifications.h
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectRareData.h
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
Log Message:
-----------
AX: Allow AXCoreObject::supportsPressAction to match the first descendant of
a clickable ancestor, even if there are other descendants who would otherwise
match
https://bugs.webkit.org/show_bug.cgi?id=298662
rdar://160294153
Reviewed by Joshua Hoffman.
Our previous heuristic was AXCoreObject::supportsPressAction was too
restrictive, preventing this repair from coming
into affect on a real webpage used for booking a haircut. Relax the heuristic a
bit, while still not making it apply
too much so that VoiceOver users don't hear / read "clickable" all over the
place. We balance this by making the heuristic
now require cursor:pointer, as lacking that, the visual experience also doesn't
indicate pressability.
*
LayoutTests/accessibility/mac/press-action-not-exposed-for-event-delegation-expected.txt:
*
LayoutTests/accessibility/mac/press-action-not-exposed-for-event-delegation.html:
*
LayoutTests/accessibility/mac/supports-press-action-with-dynamic-cursor-type-expected.txt:
Added.
*
LayoutTests/accessibility/mac/supports-press-action-with-dynamic-cursor-type.html:
Added.
* LayoutTests/accessibility/onclick-handlers.html:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::supportsPressAction const):
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::AXCoreObject::isCursorClickable const):
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXNotifications.h:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::onStyleChange):
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AXObjectRareData.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
(WebCore::convertToPropertyFlag):
(WebCore::createIsolatedObjectData):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
Canonical link: https://commits.webkit.org/299991@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
