Title: [113305] trunk/LayoutTests
- Revision
- 113305
- Author
- [email protected]
- Date
- 2012-04-05 02:25:20 -0700 (Thu, 05 Apr 2012)
Log Message
[GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC
https://bugs.webkit.org/show_bug.cgi?id=83137
Patch by ChangSeok Oh <[email protected]> on 2012-04-05
Reviewed by Kentaro Hara.
fast/filesystem/flags-passing.html is failed on webkitgtk+ applied FileSystem API patch
for bug58443. 'testsList' is a global array object, but it's accessed in runNextTest
function object like this, "this[testsList[testCounter++]]();". I'm not familiar
with _javascript_ and V8, but in my understanding, it looks a bit strange.
'this' in the statement means runNextTest function object which doesn't have
testList array object. (It's a global scope variable.) This test might be able to
pass on V8 JS engine, but not on JSC at least my try.
'testsList' is changed from a function name array to a function array.
* fast/filesystem/script-tests/flags-passing.js:
(runNextTest):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (113304 => 113305)
--- trunk/LayoutTests/ChangeLog 2012-04-05 09:13:34 UTC (rev 113304)
+++ trunk/LayoutTests/ChangeLog 2012-04-05 09:25:20 UTC (rev 113305)
@@ -1,3 +1,22 @@
+2012-04-05 ChangSeok Oh <[email protected]>
+
+ [GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC
+ https://bugs.webkit.org/show_bug.cgi?id=83137
+
+ Reviewed by Kentaro Hara.
+
+ fast/filesystem/flags-passing.html is failed on webkitgtk+ applied FileSystem API patch
+ for bug58443. 'testsList' is a global array object, but it's accessed in runNextTest
+ function object like this, "this[testsList[testCounter++]]();". I'm not familiar
+ with _javascript_ and V8, but in my understanding, it looks a bit strange.
+ 'this' in the statement means runNextTest function object which doesn't have
+ testList array object. (It's a global scope variable.) This test might be able to
+ pass on V8 JS engine, but not on JSC at least my try.
+ 'testsList' is changed from a function name array to a function array.
+
+ * fast/filesystem/script-tests/flags-passing.js:
+ (runNextTest):
+
2012-04-05 Philippe Normand <[email protected]>
Unreviewed, GTK test_expectations update after r113292.
Modified: trunk/LayoutTests/fast/filesystem/script-tests/flags-passing.js (113304 => 113305)
--- trunk/LayoutTests/fast/filesystem/script-tests/flags-passing.js 2012-04-05 09:13:34 UTC (rev 113304)
+++ trunk/LayoutTests/fast/filesystem/script-tests/flags-passing.js 2012-04-05 09:25:20 UTC (rev 113305)
@@ -8,12 +8,12 @@
var unexpected = function(e) { unexpectedCallbacksCount++; };
var testsList = [
- 'runObjectTest',
- 'cleanupAndRunNext',
- 'runJSONTest',
- 'runJSONTestWithExclusive',
- 'runNullTest',
- 'runNonObjectTest'
+ runObjectTest,
+ cleanupAndRunNext,
+ runJSONTest,
+ runJSONTestWithExclusive,
+ runNullTest,
+ runNonObjectTest
];
var testCounter = 0;
@@ -24,7 +24,7 @@
shouldBe('unexpectedCallbacksCount', '0');
finishJSTest();
} else
- this[testsList[testCounter++]]();
+ (testsList[testCounter++])();
}
function errorCallback(error) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
