Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e533155ab7c237c95febdc0cdafd526d752faacc
https://github.com/WebKit/WebKit/commit/e533155ab7c237c95febdc0cdafd526d752faacc
Author: Timothy Hatcher <timo...@apple.com>
Date: 2025-09-17 (Wed, 17 Sep 2025)
Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtension.cpp
M
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIActionCocoa.mm
M Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm
Log Message:
-----------
Add support for using SF Symbols as Web Extension icons.
https://webkit.org/b/298978
rdar://problem/160723485
Reviewed by Brian Weinstein.
Allow `"symbol:name"` to be used where any image path is allowed to use a
system SF Symbol.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::resourceDataForPath):
(WebKit::WebExtension::iconForPath):
* Source/WebKit/UIProcess/Extensions/WebExtension.cpp:
(WebKit::WebExtension::resourceMIMETypeForPath):
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIActionCocoa.mm:
(WebKit::WebExtensionAPIAction::parseIconPath):
* Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm:
(TestWebKitAPI::TEST(WKWebExtension, SymbolImageIcon)): Added.
(TestWebKitAPI::TEST(WKWebExtension, SymbolImageIconVariant)): Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIAction, SetIconSymbolSinglePath)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPIAction, SetIconSymbolIconsDictionary)):
Added.
(TestWebKitAPI::TEST(WKWebExtensionAPIAction, SetIconWithSymbolVariants)):
Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus,
MenuItemWithSymbolImageIconVariants)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPIMenus, MenuItemWithSymbolImageIcon)):
Added.
Canonical link: https://commits.webkit.org/300080@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
