Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 93c69674e9dabdf031e0b57316c3fe916c823e22
      
https://github.com/WebKit/WebKit/commit/93c69674e9dabdf031e0b57316c3fe916c823e22
  Author: Pascoe <pas...@apple.com>
  Date:   2025-09-17 (Wed, 17 Sep 2025)

  Changed paths:
    M 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm

  Log Message:
  -----------
  [WebAuthn] Return attachment=cross-platform for security key 
creates/assertions
rdar://156414985
https://bugs.webkit.org/show_bug.cgi?id=298932

Reviewed by Charlie Wolfe.

Whenever we switched over to using AuthenticationServices API, we stopped 
setting
attachment=cross-platform for security key requests. This patch fixes that.

Unfortunately we cannot presently test the path that this change takes. We 
should be
able to once we extend AuthenticationServices testing framework to set a mock 
configuration
from within the AuthenticationServicesAgent process. That work is represented 
by https://bugs.webkit.org/show_bug.cgi?id=298932.

* 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::fromASAuthorizationPublicKeyCredentialAttachment):
(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):

Canonical link: https://commits.webkit.org/300084@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to