Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 660e8c21bf9078fcac94ada906ce87e3262d73bf
      
https://github.com/WebKit/WebKit/commit/660e8c21bf9078fcac94ada906ce87e3262d73bf
  Author: Ryosuke Niwa <rn...@webkit.org>
  Date:   2025-09-11 (Thu, 11 Sep 2025)

  Changed paths:
    M Source/WebCore/editing/EditingStyle.cpp

  Log Message:
  -----------
  Avoid unnecessary ref churn in identifierForStyleProperty in EditingStyle.cpp
https://bugs.webkit.org/show_bug.cgi?id=298705

Reviewed by Vitor Roriz and Chris Dumez.

The static analyzer was getting confused by `RefPtr fontStyleValue`. Because it 
comes from `auto`,
it couldn't deduce that we're using `RefPtr` as the actual template so it gives 
up determining the type.
This PR fixes eliminates this ambiguity by explicitly declaring the type of 
`value` and removes the
superfluous construction of Ref in calling 
fontStyleAngleFromCSSFontStyleWithAngleValueDeprecated.

* Source/WebCore/editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):

Canonical link: https://commits.webkit.org/299860@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to