Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c5816eb46c58597899b924f0e716288aaf99414e
      
https://github.com/WebKit/WebKit/commit/c5816eb46c58597899b924f0e716288aaf99414e
  Author: Carlos Alberto Lopez Perez <clo...@igalia.com>
  Date:   2025-09-17 (Wed, 17 Sep 2025)

  Changed paths:
    M Tools/CISupport/build-webkit-org/steps.py
    M Tools/CISupport/build-webkit-org/steps_unittest.py
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [build.webkit.org][ews-build] The return code from the command executed is 
not forwarded properly on step run-api-tests
https://bugs.webkit.org/show_bug.cgi?id=297755

Reviewed by Brianna Fan.

The shell command added in 279232@main and 292611@main to save the logs on a 
file and then grep
for the final result is masking the return code of the command executed to run 
the tests.

The return code is always zero (assuming that grep can find the "Ran " string)

Fix that by saving the return code of the command to run the tests on a env 
variable and
returning that instead.

* Tools/CISupport/build-webkit-org/steps.py:
(RunAPITests.run):
* Tools/CISupport/build-webkit-org/steps_unittest.py:
* Tools/CISupport/ews-build/steps.py:
(RunAPITests.run):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/300102@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to