Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 412a6c047fa6e7ba2062e1bbd8afc707931b7cab
      
https://github.com/WebKit/WebKit/commit/412a6c047fa6e7ba2062e1bbd8afc707931b7cab
  Author: Cole Carley <ccarl...@apple.com>
  Date:   2025-09-17 (Wed, 17 Sep 2025)

  Changed paths:
    M JSTests/ChakraCore/test/EH/try.bug188541.v5.baseline-jsc
    M JSTests/ChakraCore/test/LetConst/AssignmentToConst.baseline-jsc
    M JSTests/ChakraCore/test/LetConst/defer2.baseline-jsc
    M JSTests/ChakraCore/test/LetConst/defer5.baseline-jsc
    M JSTests/ChakraCore/test/LetConst/storeundecl_eval.baseline-jsc
    M JSTests/ChakraCore/test/LetConst/storeundecl_multiscript.baseline-jsc
    M JSTests/ChakraCore/test/LetConst/tdz1.baseline-jsc
    M JSTests/ChakraCore/test/LetConst/with.baseline-jsc
    M JSTests/ChakraCore/test/UnitTestFramework/UnitTestFramework.js
    M JSTests/ChakraCore/test/es6/letconst_global_shadow_builtins.baseline-jsc
    M JSTests/ChakraCore/test/es6/letconst_global_shadowing.baseline-jsc
    M JSTests/ChakraCore/test/es6/unicode_blue_533163_utf8.baseline-jsc
    M JSTests/modules/cyclic-may-produce-tdz/1.js
    M 
JSTests/modules/exported-function-may-be-called-before-module-is-executed/1.js
    M JSTests/modules/module-eval/A.js
    M JSTests/modules/module-namespace-is-frozen.js
    M JSTests/modules/module-namespace-is-sealed.js
    M JSTests/modules/namespace-empty.js
    M JSTests/modules/namespace-object-get-property.js
    M JSTests/modules/namespace-tdz/B.js
    M JSTests/stress/class-expression-should-be-tdz-in-heritage.js
    M JSTests/stress/class-expression-should-store-result-at-last.js
    M 
JSTests/stress/const-lexical-binding-shadow-existing-global-property-tdz-ftl.js
    M 
JSTests/stress/const-lexical-binding-shadow-existing-global-property-tdz.js
    M JSTests/stress/for-of-tdz-with-try-catch.js
    M 
JSTests/stress/function-constructor-reading-from-global-lexical-environment.js
    M JSTests/stress/generator-frame-empty.js
    M JSTests/stress/jsonp-program-evaluate-path-must-handle-tdz.js
    M 
JSTests/stress/let-lexical-binding-shadow-existing-global-property-tdz-ftl.js
    M JSTests/stress/let-lexical-binding-shadow-existing-global-property-tdz.js
    M JSTests/stress/object-pattern-simple-fast-path.js
    M JSTests/stress/parameter-scoping.js
    M JSTests/stress/regress-185995.js
    M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-2-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-events-and-exceptions-expected.txt
    M LayoutTests/js/arguments-iterator-expected.txt
    M LayoutTests/js/class-syntax-name-expected.txt
    M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp
    M Source/JavaScriptCore/dfg/DFGOperations.cpp
    M Source/JavaScriptCore/interpreter/Interpreter.cpp
    M Source/JavaScriptCore/jit/JITOperations.cpp
    M Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
    M Source/JavaScriptCore/parser/ASTBuilder.h
    M Source/JavaScriptCore/parser/NodeConstructors.h
    M Source/JavaScriptCore/parser/Nodes.h
    M Source/JavaScriptCore/parser/Parser.cpp
    M Source/JavaScriptCore/parser/SourceProvider.h
    M Source/JavaScriptCore/parser/SyntaxChecker.h
    M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp
    M Source/JavaScriptCore/runtime/ExceptionHelpers.cpp
    M Source/JavaScriptCore/runtime/ExceptionHelpers.h
    M Source/JavaScriptCore/runtime/JSModuleNamespaceObject.cpp

  Log Message:
  -----------
  ReferenceError doesn't include variable name in error message
https://bugs.webkit.org/show_bug.cgi?id=275143
rdar://129659300

Reviewed by Keith Miller.

This improves the JSC `ReferenceError` caused by a tdz error by including the 
variable name in the message. Both Chrome and Firefox do this.
This is achieved by emitting `ExpressionInfo` in the bytecode that corresponds 
to the identifier. The `ExpressionInfo` is
then used when there is a tdz error. A majority of the changes are fixing tests 
to follow this format, and the most important changes are
in `NodesCodegen.cpp`

Canonical link: https://commits.webkit.org/300119@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to