Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d4cc14a231eab87f2ff577f2a8c50a6f74ce7366
https://github.com/WebKit/WebKit/commit/d4cc14a231eab87f2ff577f2a8c50a6f74ce7366
Author: Richard Robinson <richard_robins...@apple.com>
Date: 2025-09-18 (Thu, 18 Sep 2025)
Changed paths:
M Source/WebCore/editing/InsertTextCommand.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SmartLists.mm
Log Message:
-----------
[Smart Lists] Smart Lists should not be activated if selection is already
within a list
https://bugs.webkit.org/show_bug.cgi?id=299066
rdar://160826918
Reviewed by Abrar Rahman Protyasha and Lily Spiniolas.
Before allowing a Smart List to be created, first check if the selection is
already within a list and exit early if so.
* Source/WebCore/editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::applySmartListsIfNeeded):
Add new guard condition to check for an enclosing list.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SmartLists.mm:
(TEST(SmartLists, InsertingSpaceAndTextAfterBulletPointGeneratesListWithText)):
(InsertingSpaceAndTextAfterHyphenGeneratesDashedList)):
((SmartLists,
InsertingSpaceAfterBulletPointInMiddleOfSentenceDoesNotGenerateList)):
((SmartLists, InsertingSpaceAfterPeriodAtStartOfSentenceDoesNotGenerateList)):
((SmartLists, InsertingSpaceAfterNumberGeneratesOrderedList)):
((SmartLists, InsertingSpaceAfterMultipleDigitNumberGeneratesOrderedList)):
Drive-by formatting fix for consistency
((SmartLists, InsertingSpaceInsideListElementDoesNotActivateSmartLists)):
New test added
Canonical link: https://commits.webkit.org/300158@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
