Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dd82ba7dac94951ec0a791f9bd9cef72c98e498c
https://github.com/WebKit/WebKit/commit/dd82ba7dac94951ec0a791f9bd9cef72c98e498c
Author: Chris Dumez <cdu...@apple.com>
Date: 2025-09-19 (Fri, 19 Sep 2025)
Changed paths:
M Source/WebCore/Modules/airplay/WebMediaSessionManager.h
M Source/WebCore/Modules/encryptedmedia/CDM.cpp
M Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp
M Source/WebCore/Modules/encryptedmedia/InitDataRegistry.h
M Source/WebCore/Modules/websockets/WebSocket.cpp
M Source/WebCore/PAL/pal/system/ios/SleepDisablerIOS.mm
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/css/CSSFontFaceSource.cpp
M Source/WebCore/css/CSSFontSelector.cpp
M Source/WebCore/dom/UserGestureIndicator.cpp
M Source/WebCore/html/HTMLCanvasElement.cpp
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/ResourceLoadObserver.cpp
M Source/WebCore/loader/ResourceLoadObserver.h
M Source/WebCore/loader/SubresourceLoader.cpp
M Source/WebCore/page/DOMWindow.cpp
M Source/WebCore/page/DeprecatedGlobalSettings.cpp
M Source/WebCore/page/DeprecatedGlobalSettings.h
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/Navigator.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Screen.cpp
M Source/WebCore/platform/graphics/GraphicsContext.cpp
M Source/WebCore/platform/graphics/ImageBufferDisplayListBackend.cpp
M Source/WebCore/platform/graphics/adwaita/ControlFactoryAdwaita.cpp
M Source/WebCore/platform/graphics/adwaita/ControlFactoryAdwaita.h
M Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp
M
Source/WebCore/platform/graphics/avfoundation/WebMediaSessionManagerMac.cpp
M Source/WebCore/platform/graphics/controls/ControlFactory.cpp
M Source/WebCore/platform/graphics/controls/ControlFactory.h
M Source/WebCore/platform/graphics/controls/ControlPart.cpp
M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp
M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h
M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm
M Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.mm
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/MockCDMFactory.cpp
M Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
M Source/WebKit/ModelProcess/ModelProcess.cpp
M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
M Source/WebKit/Platform/cocoa/WebPrivacyHelpers.h
M Source/WebKit/Platform/cocoa/WebPrivacyHelpers.mm
M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp
M Source/WebKit/WebProcess/WebProcess.cpp
M
Source/WebKitLegacy/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebKitLegacy/mac/WebView/WebMediaPlaybackTargetPicker.mm
Log Message:
-----------
[Safer CPP] Rename singleton functions from `shared()` to `singleton()`
https://bugs.webkit.org/show_bug.cgi?id=299144
Reviewed by Ryosuke Niwa.
Rename singleton functions from `shared()` to `singleton()` to help
Safer CPP static analysis understand lifetime.
* Source/WebCore/Modules/airplay/WebMediaSessionManager.h:
* Source/WebCore/Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::sanitizeInitData):
* Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp:
(WebCore::InitDataRegistry::singleton):
(WebCore::InitDataRegistry::shared): Deleted.
* Source/WebCore/Modules/encryptedmedia/InitDataRegistry.h:
* Source/WebCore/Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* Source/WebCore/PAL/pal/system/ios/SleepDisablerIOS.mm:
(PAL::ScreenSleepDisabler::singleton):
(PAL::SleepDisablerCocoa::takeScreenSleepDisablingAssertion):
(PAL::SleepDisablerCocoa::setScreenWakeLockHandler):
(PAL::ScreenSleepDisabler::shared): Deleted.
* Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::load):
* Source/WebCore/css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::fontRangesForFamily):
(WebCore::CSSFontSelector::fallbackFontAt):
* Source/WebCore/dom/UserGestureIndicator.cpp:
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toDataURL):
(WebCore::HTMLCanvasElement::toBlob):
(WebCore::HTMLCanvasElement::getImageData):
(WebCore::HTMLCanvasElement::toVideoFrame):
(WebCore::HTMLCanvasElement::captureStream):
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::logUserInteraction):
* Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::measureText):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
* Source/WebCore/loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::singleton):
(WebCore::ResourceLoadObserver::singletonIfExists):
(WebCore::ResourceLoadObserver::shared): Deleted.
(WebCore::ResourceLoadObserver::sharedIfExists): Deleted.
* Source/WebCore/loader/ResourceLoadObserver.h:
* Source/WebCore/loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::close):
* Source/WebCore/page/DeprecatedGlobalSettings.cpp:
(WebCore::DeprecatedGlobalSettings::singleton):
(WebCore::DeprecatedGlobalSettings::setAVFoundationEnabled):
(WebCore::DeprecatedGlobalSettings::setGStreamerEnabled):
(WebCore::DeprecatedGlobalSettings::setMockScrollbarsEnabled):
(WebCore::DeprecatedGlobalSettings::setUsesOverlayScrollbars):
(WebCore::DeprecatedGlobalSettings::setTrackingPreventionEnabled):
(WebCore::DeprecatedGlobalSettings::setNetworkInterfaceName):
(WebCore::DeprecatedGlobalSettings::setAllowsAnySSLCertificate):
(WebCore::DeprecatedGlobalSettings::allowsAnySSLCertificate):
(WebCore::DeprecatedGlobalSettings::builtInNotificationsEnabled):
(WebCore::DeprecatedGlobalSettings::shared): Deleted.
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::isAVFoundationEnabled):
(WebCore::DeprecatedGlobalSettings::isGStreamerEnabled):
(WebCore::DeprecatedGlobalSettings::mockScrollbarsEnabled):
(WebCore::DeprecatedGlobalSettings::usesOverlayScrollbars):
(WebCore::DeprecatedGlobalSettings::lowPowerVideoAudioBufferSizeEnabled):
(WebCore::DeprecatedGlobalSettings::setLowPowerVideoAudioBufferSizeEnabled):
(WebCore::DeprecatedGlobalSettings::trackingPreventionEnabled):
(WebCore::DeprecatedGlobalSettings::networkInterfaceName):
(WebCore::DeprecatedGlobalSettings::setDisableScreenSizeOverride):
(WebCore::DeprecatedGlobalSettings::disableScreenSizeOverride):
(WebCore::DeprecatedGlobalSettings::setShouldOptOutOfNetworkStateObservation):
(WebCore::DeprecatedGlobalSettings::shouldOptOutOfNetworkStateObservation):
(WebCore::DeprecatedGlobalSettings::setCustomPasteboardDataEnabled):
(WebCore::DeprecatedGlobalSettings::customPasteboardDataEnabled):
(WebCore::DeprecatedGlobalSettings::setAttrStyleEnabled):
(WebCore::DeprecatedGlobalSettings::attrStyleEnabled):
(WebCore::DeprecatedGlobalSettings::setWebSQLEnabled):
(WebCore::DeprecatedGlobalSettings::webSQLEnabled):
(WebCore::DeprecatedGlobalSettings::setAttachmentElementEnabled):
(WebCore::DeprecatedGlobalSettings::attachmentElementEnabled):
(WebCore::DeprecatedGlobalSettings::webRTCAudioLatencyAdaptationEnabled):
(WebCore::DeprecatedGlobalSettings::setWebRTCAudioLatencyAdaptationEnabled):
(WebCore::DeprecatedGlobalSettings::setReadableByteStreamAPIEnabled):
(WebCore::DeprecatedGlobalSettings::readableByteStreamAPIEnabled):
(WebCore::DeprecatedGlobalSettings::setIsAccessibilityIsolatedTreeEnabled):
(WebCore::DeprecatedGlobalSettings::isAccessibilityIsolatedTreeEnabled):
(WebCore::DeprecatedGlobalSettings::setAccessibilityThreadTextApisEnabled):
(WebCore::DeprecatedGlobalSettings::accessibilityThreadTextApisEnabled):
(WebCore::DeprecatedGlobalSettings::setArePDFImagesEnabled):
(WebCore::DeprecatedGlobalSettings::arePDFImagesEnabled):
(WebCore::DeprecatedGlobalSettings::setBuiltInNotificationsEnabled):
(WebCore::DeprecatedGlobalSettings::setModelDocumentEnabled):
(WebCore::DeprecatedGlobalSettings::modelDocumentEnabled):
(WebCore::DeprecatedGlobalSettings::setUsesWebContentRestrictionsForFilter):
(WebCore::DeprecatedGlobalSettings::usesWebContentRestrictionsForFilter):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
* Source/WebCore/page/Navigator.cpp:
(WebCore::Navigator::appVersion const):
(WebCore::Navigator::userAgent const):
(WebCore::Navigator::plugins):
(WebCore::Navigator::mimeTypes):
(WebCore::Navigator::cookieEnabled const):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::setLastAuthentication):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::hasStorageAccessForAllLoginDomains):
(WebCore::Quirks::requestStorageAccessAndHandleClick const):
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
* Source/WebCore/page/Screen.cpp:
(WebCore::Screen::height const):
(WebCore::Screen::width const):
(WebCore::Screen::colorDepth const):
(WebCore::Screen::availLeft const):
(WebCore::Screen::availTop const):
(WebCore::Screen::availHeight const):
(WebCore::Screen::availWidth const):
* Source/WebCore/platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawDisplayList):
* Source/WebCore/platform/graphics/ImageBufferDisplayListBackend.cpp:
(WebCore::ImageBufferDisplayListBackend::create):
* Source/WebCore/platform/graphics/adwaita/ControlFactoryAdwaita.cpp:
(WebCore::ControlFactoryAdwaita::singleton):
(WebCore::ControlFactoryAdwaita::shared): Deleted.
* Source/WebCore/platform/graphics/adwaita/ControlFactoryAdwaita.h:
* Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
(WebCore::CDMFactory::platformRegisterFactories):
* Source/WebCore/platform/graphics/avfoundation/WebMediaSessionManagerMac.cpp:
(WebCore::WebMediaSessionManager::singleton):
(WebCore::WebMediaSessionManager::shared): Deleted.
* Source/WebCore/platform/graphics/controls/ControlFactory.cpp:
(WebCore::ControlFactory::singleton):
(WebCore::ControlFactory::shared): Deleted.
* Source/WebCore/platform/graphics/controls/ControlFactory.h:
* Source/WebCore/platform/graphics/controls/ControlPart.cpp:
(WebCore::ControlPart::controlFactory const):
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::appendDisplayList):
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm:
(WebCore::ControlFactoryMac::singleton):
(WebCore::ControlFactoryMac::shared): Deleted.
* Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.mm:
(WebCore::ImageControlsButtonMac::servicesRolloverButtonCellSize):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::resourceLoadStatisticsForURL):
(WebCore::Internals::notifyResourceLoadObserver):
* Source/WebCore/testing/MockCDMFactory.cpp:
(WebCore::MockCDMInstanceSession::requestLicense):
* Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::ServiceWorkerThread):
* Source/WebKit/ModelProcess/ModelProcess.cpp:
(WebKit::ModelProcess::createModelConnectionToWebProcess):
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::ModelProcessModelPlayerProxy::load):
* Source/WebKit/Platform/cocoa/WebPrivacyHelpers.h:
* Source/WebKit/Platform/cocoa/WebPrivacyHelpers.mm:
(WebKit::RestrictedOpenerDomainsController::singleton):
(WebKit::RestrictedOpenerDomainsController::shared): Deleted.
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::loadRestrictedOpenerTypeDataIfNeeded):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::openerTypeForDomain const):
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::mediaSessionManager):
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleClearResourceLoadStatistics):
(WKBundleResourceLoadStatisticsNotifyObserver):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setWebsiteDataStoreParameters):
(WebKit::WebProcess::setTrackingPreventionEnabled):
(WebKit::WebProcess::clearResourceLoadStatistics):
(WebKit::WebProcess::flushResourceLoadStatistics):
(WebKit::WebProcess::seedResourceLoadStatisticsForTesting):
(WebKit::WebProcess::setDomainsWithUserInteraction):
(WebKit::WebProcess::setDomainsWithCrossPageStorageAccess):
(WebKit::WebProcess::sendResourceLoadStatisticsDataImmediately):
* Source/WebKitLegacy/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebKitLegacy/mac/WebView/WebMediaPlaybackTargetPicker.mm:
(WebMediaPlaybackTargetPicker::addPlaybackTargetPickerClient):
(WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
(WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
(WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
(WebMediaPlaybackTargetPicker::setMockMediaPlaybackTargetPickerEnabled):
(WebMediaPlaybackTargetPicker::setMockMediaPlaybackTargetPickerState):
(WebMediaPlaybackTargetPicker::mockMediaPlaybackTargetPickerDismissPopup):
(WebMediaPlaybackTargetPicker::invalidate):
Canonical link: https://commits.webkit.org/300229@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
